Skip to content

Conversation

@arjan-bal
Copy link
Contributor

Original PR: #8528
Related issue: #8517

RELEASE NOTES:

  • server: Fix bug preventing streams from being cancelled or timed out when blocked on flow control.
…ow control (grpc#8528)

Fixes: grpc#8517

This change allows `t.closeStream()` to be executed even if the stream
state is `done`. This is required to allow streams to be cancelled to
timed out. See issue for detailed root cause.

RELEASE NOTES:
* server: Fix bug preventing streams from being cancelled or timed out
when blocked on flow control.
@arjan-bal arjan-bal added this to the 1.75 Release milestone Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.88%. Comparing base (a52e42b) to head (7f68b5a).
⚠️ Report is 1 commits behind head on v1.75.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.75.x    #8555      +/-   ##
===========================================
+ Coverage    81.57%   81.88%   +0.30%     
===========================================
  Files          413      413              
  Lines        40623    40535      -88     
===========================================
+ Hits         33138    33191      +53     
+ Misses        6023     5976      -47     
+ Partials      1462     1368      -94     
Files with missing lines Coverage Δ
internal/transport/http2_server.go 90.87% <100.00%> (+0.27%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@arjan-bal arjan-bal merged commit 1fffee7 into grpc:v1.75.x Sep 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants