Skip to content

Conversation

@kevinGC
Copy link
Contributor

@kevinGC kevinGC commented Aug 13, 2025

It's generally useful to have new-and-improved Go. One specific useful feature is b.Loop(), which makes benchmarking easier.

Encountered while working on #8510, as I was using b.Loop() in my benchmarks.

RELEASE NOTES:

  • Minimum supported Go version is now 1.24
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.74%. Comparing base (55e8b90) to head (5a59d02).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8509      +/-   ##
==========================================
- Coverage   82.40%   81.74%   -0.66%     
==========================================
  Files         414      413       -1     
  Lines       40531    40525       -6     
==========================================
- Hits        33399    33129     -270     
- Misses       5770     6008     +238     
- Partials     1362     1388      +26     

see 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@kevinGC kevinGC changed the title bump go version to 1.24 Aug 13, 2025
@arjan-bal
Copy link
Contributor

Hi @kevinGC, can you also bump the Go versions used for CI tests similar to this change?

@arjan-bal arjan-bal self-requested a review August 14, 2025 08:26
@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Aug 14, 2025
@arjan-bal arjan-bal added this to the 1.76 Release milestone Aug 14, 2025
It's generally useful to have new-and-improved Go. One specific useful
feature is `b.Loop()`, which makes benchmarking easier.
@kevinGC
Copy link
Contributor Author

kevinGC commented Aug 14, 2025

Thanks for the review. Done.

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding a second reviewer.

Just FYI, gRPC Go supports the two most recent major versions of Golang, which aligns with Go's support policy. I'm not sure if it's a coincidence that this PR came just 6 hours after Go 1.25 was released. :)

@arjan-bal arjan-bal assigned dfawley and unassigned kevinGC Aug 14, 2025
@arjan-bal arjan-bal requested a review from dfawley August 14, 2025 18:05
@dfawley dfawley merged commit e847f29 into grpc:master Aug 14, 2025
17 checks passed
dimpavloff pushed a commit to dimpavloff/grpc-go that referenced this pull request Aug 22, 2025
@ldemailly
Copy link

personally I find it annoying when a library forces a bump without taking advantage of any actual feature - ie a just bumping while things compile fine with older

(ps not to say that that when building end product one shouldn't indeed use the most recent stable patch (1.24.8 as of this writing) but forcing cascading bumps into dependencies is annoying (and golang.org/x is a prime culprit there but it would be nice the rest of the ecosystem doesn't imitate bad things))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Dependencies Updating/adding/removing dependencies

4 participants