Skip to content

Conversation

@arjan-bal
Copy link
Contributor

Internal issue: b/397462082

The format of the locality ID used for reporting metrics is specified here: https://github.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md#optional-xds-locality-label

gRPC Go uses JSON which is inconsistent with other gRPC implementations. This PR fixes this.

RELEASE NOTES:

  • xds: Locality ID metric label is changed to make it consistent with gRFC A78.
@arjan-bal arjan-bal added Type: Bug Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Apr 16, 2025
@arjan-bal arjan-bal added this to the 1.73 Release milestone Apr 16, 2025
@arjan-bal arjan-bal requested review from dfawley and easwars April 16, 2025 09:28
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (f0676ea) to head (1ea4f19).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8256      +/-   ##
==========================================
+ Coverage   82.01%   82.23%   +0.22%     
==========================================
  Files         412      412              
  Lines       40488    40477      -11     
==========================================
+ Hits        33206    33287      +81     
+ Misses       5900     5834      -66     
+ Partials     1382     1356      -26     
Files with missing lines Coverage Δ
xds/internal/balancer/clusterimpl/picker.go 100.00% <100.00%> (+3.00%) ⬆️
...internal/balancer/clusterresolver/configbuilder.go 92.85% <100.00%> (+1.62%) ⬆️
xds/internal/balancer/wrrlocality/balancer.go 68.13% <100.00%> (+2.86%) ⬆️
xds/internal/internal.go 76.00% <100.00%> (+7.03%) ⬆️
...ds/internal/xdsclient/xdsresource/unmarshal_eds.go 95.13% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
TotalDrops: dropCount,
Drops: map[string]uint64{dropReason: dropCount},
LocalityStats: map[string]load.LocalityData{
assertString(xdsinternal.LocalityID{}.ToString): {RequestStats: load.RequestData{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete assertString since it is unused now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@dfawley dfawley assigned arjan-bal and unassigned easwars and dfawley Apr 16, 2025
@arjan-bal arjan-bal merged commit 718c4d8 into grpc:master Apr 17, 2025
23 of 24 checks passed
@arjan-bal arjan-bal deleted the fix-xds-locality-format branch April 17, 2025 07:12
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug

3 participants