Skip to content

Commit 7af6523

Browse files
authored
testing: remove testing identity override (#2011)
* testing: remove testing identity override This PR removes a stale reference to a membership group in samples tests.
1 parent ea69fe3 commit 7af6523

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

‎samples/snippets/view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def grant_access(
147147
# Make an API request to get the view dataset ACLs.
148148
view_dataset = client.get_dataset(view_dataset_id)
149149

150-
analyst_group_email = "data_analysts@example.com"
150+
analyst_group_email = "example-analyst-group@google.com"
151151
# [END bigquery_grant_view_access]
152152
# To facilitate testing, we replace values with alternatives
153153
# provided by the testing harness.

‎samples/snippets/view_test.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def test_view(
114114

115115
project_id, dataset_id, table_id = view_id.split(".")
116116
overrides: view.OverridesDict = {
117-
"analyst_group_email": "cloud-dpes-bigquery@google.com",
118117
"view_dataset_id": view_dataset_id,
119118
"source_dataset_id": source_dataset_id,
120119
"view_reference": {
@@ -127,5 +126,5 @@ def test_view(
127126
assert len(view_dataset.access_entries) != 0
128127
assert len(source_dataset.access_entries) != 0
129128
out, _ = capsys.readouterr()
130-
assert "cloud-dpes-bigquery@google.com" in out
129+
assert "example-analyst-group@google.com" in out
131130
assert table_id in out

0 commit comments

Comments
 (0)