-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Comparing changes
Open a pull request
base repository: golang/go
base: go1.24.2
head repository: golang/go
compare: go1.24.3
- 11 commits
- 37 files changed
- 10 contributors
Commits on Apr 3, 2025
-
[release-branch.go1.24] os: avoid panic in Root when symlink referenc…
…es the root We would panic when opening a symlink ending in .., where the symlink references the root itself. For #73081 Fixes #73082 Change-Id: I7dc3f041ca79df7942feec58c197fde6881ecae5 Reviewed-on: https://go-review.googlesource.com/c/go/+/661416 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit cfc784a) Reviewed-on: https://go-review.googlesource.com/c/go/+/662315
Configuration menu - View commit details
-
Copy full SHA for fa7217f - Browse repository at this point
Copy the full SHA fa7217fView commit details
Commits on Apr 10, 2025
-
[release-branch.go1.24] cmd/link: choose one with larger size for dup…
…licated BSS symbols When two packages declare a variable with the same name (with linkname at least on one side), the linker will choose one as the actual definition of the symbol if one has content (i.e. a DATA symbol) and the other does not (i.e. a BSS symbol). When both have content, it is redefinition error. When neither has content, currently the choice is sort of arbitrary (depending on symbol loading order, etc. which are subject to change). One use case for that is that one wants to reference a symbol defined in another package, and the reference side just wants to see some of the fields, so it may be declared with a smaller type. In this case, we want to choose the one with the larger size as the true definition. Otherwise the code accessing the larger sized one may read/write out of bounds, corrupting the next variable. This CL makes the linker do so. Also include the followup fix CL 661915. Fixes #73092. Updates #72032. Change-Id: I160aa9e0234702066cb8f141c186eaa89d0fcfed Reviewed-on: https://go-review.googlesource.com/c/go/+/660696 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Than McIntosh <thanm@golang.org> (cherry picked from commit 8f6c083) Reviewed-on: https://go-review.googlesource.com/c/go/+/662335 Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Configuration menu - View commit details
-
Copy full SHA for a9d9b55 - Browse repository at this point
Copy the full SHA a9d9b55View commit details
Commits on Apr 28, 2025
-
[release-branch.go1.24] crypto/tls: fix ECH compatibility
Previously, the code only checked supportedVersions[0] for TLS 1.3 However, Chromium-based browsers may list TLS 1.3 at different positions, causing ECH failures. This fix: Iterates through supportedVersions to accept connections as long as TLS 1.3 is present. Improves ECH compatibility, ensuring Chrome, Edge, and other browsers work properly. Fixes #73118 Change-Id: I32f4219fb6654d5cc22c7f33497c6142c0acb4f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/648015 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Daniel McCarney <daniel@binaryparadox.net> (cherry picked from commit cd2f347) Reviewed-on: https://go-review.googlesource.com/c/go/+/661936 Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: 古大羊 <lj1788@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b2c005e - Browse repository at this point
Copy the full SHA b2c005eView commit details -
[release-branch.go1.24] runtime: fix 9-arg syscall on darwin/amd64
The last 3 arguments need to be passed on the stack, not registers. Fixes #73379 Change-Id: Ib1155ad1a805957fad3d9594c93981a558755591 Reviewed-on: https://go-review.googlesource.com/c/go/+/665435 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> (cherry picked from commit 9d7de04) Reviewed-on: https://go-review.googlesource.com/c/go/+/665995
Configuration menu - View commit details
-
Copy full SHA for 43130af - Browse repository at this point
Copy the full SHA 43130afView commit details -
[release-branch.go1.24] internal/runtime/maps: pass proper func PC to…
… race.WritePC/race.ReadPC Fixes #73192 For #73191 Change-Id: I0f8a5a19faa745943a98476c7caf4c97ccdce184 Reviewed-on: https://go-review.googlesource.com/c/go/+/663175 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> (cherry picked from commit 14b15a2) Reviewed-on: https://go-review.googlesource.com/c/go/+/663777 Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Junyang Shao <shaojunyang@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
Configuration menu - View commit details
-
Copy full SHA for 56eb998 - Browse repository at this point
Copy the full SHA 56eb998View commit details -
[release-branch.go1.24] runtime: cleanup M vgetrandom state before dr…
…opping P When an M is destroyed, we put its vgetrandom state back on the shared list for another M to reuse. This list is simply a slice, so appending to the slice may allocate. Currently this operation is performed in mdestroy, after the P is released, meaning allocation is not allowed. More the cleanup earlier in mdestroy when allocation is still OK. Also add //go:nowritebarrierrec to mdestroy since it runs without a P, which would have caught this bug. Fixes #73144. For #73141. Change-Id: I6a6a636c3fbf5c6eec09d07a260e39dbb4d2db12 Reviewed-on: https://go-review.googlesource.com/c/go/+/662455 Reviewed-by: Jason Donenfeld <Jason@zx2c4.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> (cherry picked from commit 0b31e6d) Reviewed-on: https://go-review.googlesource.com/c/go/+/662496
Configuration menu - View commit details
-
Copy full SHA for 0ab64e2 - Browse repository at this point
Copy the full SHA 0ab64e2View commit details -
[release-branch.go1.24] cmd/go/internal/load: join incompatible and d…
…irty build specifiers with . Change "+incompatible+dirty" version to be "+incompatible.dirty" such that it is SemVer spec compatible. Fixes #73500 Change-Id: I714ffb3f1ad88c793656c3652367db34739a2144 Reviewed-on: https://go-review.googlesource.com/c/go/+/652955 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Michael Matloob <matloob@golang.org> (cherry picked from commit a6e7445) Reviewed-on: https://go-review.googlesource.com/c/go/+/668135
Configuration menu - View commit details
-
Copy full SHA for c1f9c2c - Browse repository at this point
Copy the full SHA c1f9c2cView commit details
Commits on Apr 29, 2025
-
[release-branch.go1.24] cmd/internal/obj/wasm: use i64 for large retu…
…rn addr Use i64 to avoid overflow when getting PC_F from the return addr. For #73246. Fixes #73281. Change-Id: I5683dccf7eada4b8536edf53e2e83116a2f6d943 GitHub-Last-Rev: 267d9a1 GitHub-Pull-Request: #73277 Reviewed-on: https://go-review.googlesource.com/c/go/+/663995 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> (cherry picked from commit d60a684) Reviewed-on: https://go-review.googlesource.com/c/go/+/668615 Reviewed-by: Carlos Amedee <carlos@golang.org>
Configuration menu - View commit details
-
Copy full SHA for f66ab65 - Browse repository at this point
Copy the full SHA f66ab65View commit details -
[release-branch.go1.24] cmd/compile: remove no-longer-necessary recur…
…sive inlining checks this does result in a little bit more inlining, cmd/compile text is 0.5% larger, bent-benchmark text geomeans grow by only 0.02%. some of our tests make assumptions about inlining. Fixes: #73440. Change-Id: I999d1798aca5dc64a1928bd434258a61e702951a Reviewed-on: https://go-review.googlesource.com/c/go/+/655157 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/666555 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Configuration menu - View commit details
-
Copy full SHA for 06fd2f1 - Browse repository at this point
Copy the full SHA 06fd2f1View commit details
Commits on May 6, 2025
-
[release-branch.go1.24] os: avoid escape from Root via paths ending i…
…n ../ The doInRoot function operates on a path split into components. The final path component retained any trailing path separator characters, to permit operations in a Root to retain the trailing-separator behavior of non-Root operations. However, doInRoot failed to take trailing separators into account when checking for .. path components. This could permit opening the parent directory of the Root with a path ending in "../". Change the split path to never include path separators in components, and handle trailing separators independently of the split path. Thanks to Dan Sebastian Thrane of SDU eScience Center for reporting this issue. Fixes #73556 Updates #73555 Fixes CVE-2025-22873 Change-Id: I9a33a145c22f5eb1dd4e4cafae5fcc61a8d4f0d4 Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2160 Reviewed-by: Neal Patel <nealpatel@google.com> Reviewed-by: Roland Shoemaker <bracewell@google.com> Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2180 Commit-Queue: Damien Neil <dneil@google.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/670357 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Configuration menu - View commit details
-
Copy full SHA for 8947f33 - Browse repository at this point
Copy the full SHA 8947f33View commit details -
[release-branch.go1.24] go1.24.3
Change-Id: I83acf5f2bda35ee81abbbb2fc6143fa6c8e342aa Reviewed-on: https://go-review.googlesource.com/c/go/+/670456 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
Configuration menu - View commit details
-
Copy full SHA for 34c8b14 - Browse repository at this point
Copy the full SHA 34c8b14View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff go1.24.2...go1.24.3