Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.22.8
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.22.9
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on Oct 2, 2024

  1. [release-branch.go1.22] runtime: fix TestGdbAutotmpTypes on gdb versi…

    …on 15
    
    On Arch Linux with gdb version 15.1, the test for TestGdbAutotmpTypes print
    the following output,
    
    ----
    ~/src/go/src/runtime
    $ go test -run=TestGdbAutotmpTypes -v
    === RUN   TestGdbAutotmpTypes
    === PAUSE TestGdbAutotmpTypes
    === CONT  TestGdbAutotmpTypes
        runtime-gdb_test.go:78: gdb version 15.1
        runtime-gdb_test.go:570: gdb output:
            Loading Go Runtime support.
            Target 'exec' cannot support this command.
            Breakpoint 1 at 0x46e416: file /tmp/TestGdbAutotmpTypes750485513/001/main.go, line 8.
    
            This GDB supports auto-downloading debuginfo from the following URLs:
              <https://debuginfod.archlinux.org>
            Enable debuginfod for this session? (y or [n]) [answered N; input not from terminal]
            Debuginfod has been disabled.
            To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
            [New LWP 355373]
            [New LWP 355374]
            [New LWP 355375]
            [New LWP 355376]
    
            Thread 1 "a.exe" hit Breakpoint 1, main.main () at /tmp/TestGdbAutotmpTypes750485513/001/main.go:8
            8       func main() {
            9               var iface interface{} = map[string]astruct{}
            All types matching regular expression "astruct":
    
            File runtime:
                    []main.astruct
                    bucket<string,main.astruct>
                    hash<string,main.astruct>
                    main.astruct
                    typedef hash<string,main.astruct> * map[string]main.astruct;
                    typedef noalg.[8]main.astruct noalg.[8]main.astruct;
                    noalg.map.bucket[string]main.astruct
        runtime-gdb_test.go:587: could not find []main.astruct; in 'info typrs astruct' output
    !!! FAIL
    exit status 1
    FAIL    runtime 0.273s
    $
    ----
    
    In the back trace for "File runtime", each output lines does not end with
    ";" anymore, while in test we check the string with it.
    
    While at it, print the expected string with "%q" instead of "%s" for
    better error message.
    
    For #67089
    Fixes #69745
    
    Change-Id: If6019ee68c0d8e495c920f98568741462c7d0fd0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/598135
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Meng Zhuo <mengzhuo1203@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    (cherry picked from commit ff695ca)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/617456
    Auto-Submit: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    shuLhan authored and gopherbot committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    29252e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. [release-branch.go1.22] cmd/link: generate Mach-O UUID when -B flag i…

    …s specified
    
    Currently, on Mach-O, the Go linker doesn't generate LC_UUID in
    internal linking mode. This causes some macOS system tools unable
    to track the binary, as well as in some cases the binary unable
    to access local network on macOS 15.
    
    This CL makes the linker start generate LC_UUID. Currently, the
    UUID is generated if the -B flag is specified. And we'll make it
    generate UUID by default in a later CL. The -B flag is currently
    for generating GNU build ID on ELF, which is a similar concept to
    Mach-O's UUID. Instead of introducing another flag, we just use
    the same flag and the same setting. Specifically, "-B gobuildid"
    will generate a UUID based on the Go build ID.
    
    Updates #68678.
    Fixes #69991.
    
    Cq-Include-Trybots: luci.golang.try:go1.22-darwin-amd64_14,go1.22-darwin-arm64_13
    Change-Id: I90089a78ba144110bf06c1c6836daf2d737ff10a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/618595
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Ingo Oeser <nightlyone@googlemail.com>
    Reviewed-by: Than McIntosh <thanm@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 20ed603)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/622596
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    TryBot-Bypass: Michael Pratt <mpratt@google.com>
    cherrymui authored and gopherbot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e3fd4ba View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. [release-branch.go1.22] cmd/cgo/internal/testcarchive: remove 1-minut…

    …e timeout
    
    The 1-minute test timeout seems a bit arbitrary. Use
    internal/testenv.Command, which applies t.Deadline to subcommand.
    
    For #67566.
    Fixes #70124.
    
    Change-Id: If84c96e353bdfaf02c9b123758198e031305ae32
    Reviewed-on: https://go-review.googlesource.com/c/go/+/599056
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    (cherry picked from commit 8c88f0c)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/623595
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    cherrymui authored and cagedmantis committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c19e588 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. [release-branch.go1.22] go1.22.9

    Change-Id: I3255f216bc6976f9b5a1b1fc4f654caa2d2bc342
    Reviewed-on: https://go-review.googlesource.com/c/go/+/626136
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8af39d3 View commit details
    Browse the repository at this point in the history
Loading