fix: inlineFragmentTypes config option (#7555)

* test: add test suite

* fix: use correct conditional

* chore: add changeset

Author: n1ru4l

.changeset/pretty-planets-occur.md

@@ -0,0 +1,6 @@
+---
+'@graphql-codegen/visitor-plugin-common': patch
+'@graphql-codegen/typescript-operations': patch
+---
+
+fix incorrect type generation when using the inlineFragmentTypes 'combine' option that resulted in generating masked fragment output.

packages/plugins/other/visitor-plugin-common/src/selection-set-to-object.ts

@@ -492,9 +492,9 @@ export class SelectionSetToObject<Config extends ParsedDocumentsConfig = ParsedD
     const fields = [...allStrings, mergedObjectsAsString].filter(Boolean);
 
     if (fragmentsSpreadUsages.length) {
-      if (this._config.inlineFragmentTypes === 'inline') {
+      if (this._config.inlineFragmentTypes === 'combine') {
         fields.push(...fragmentsSpreadUsages);
-      } else {
+      } else if (this._config.inlineFragmentTypes === 'mask') {
         fields.push(`{ ' $fragmentRefs': { ${fragmentsSpreadUsages.map(name => `'${name}': ${name}`).join(`;`)} } }`);
       }
     }

packages/plugins/typescript/operations/tests/ts-documents.spec.ts

@@ -6029,4 +6029,93 @@ function test(q: GetEntityBrandDataQuery): void {
       );
     `);
   });
+
+  describe('inlineFragmentTypes option', () => {
+    it("'combine' yields correct types", async () => {
+      const ast = parse(/* GraphQL */ `
+        query {
+          me {
+            ...UserFragment
+          }
+        }
+        fragment UserFragment on User {
+          id
+        }
+      `);
+      const result = await plugin(
+        schema,
+        [{ location: 'test-file.ts', document: ast }],
+        { inlineFragmentTypes: 'combine' },
+        { outputFile: '' }
+      );
+      expect(result.content).toBeSimilarStringTo(`
+        export type Unnamed_1_QueryVariables = Exact<{ [key: string]: never; }>;
+
+
+        export type Unnamed_1_Query = { __typename?: 'Query', me?: (
+            { __typename?: 'User' }
+            & UserFragmentFragment
+          ) | null };
+
+        export type UserFragmentFragment = { __typename?: 'User', id: string };
+      `);
+    });
+
+    it("'inline' yields correct types", async () => {
+      const ast = parse(/* GraphQL */ `
+        query {
+          me {
+            ...UserFragment
+          }
+        }
+        fragment UserFragment on User {
+          id
+        }
+      `);
+      const result = await plugin(
+        schema,
+        [{ location: 'test-file.ts', document: ast }],
+        { inlineFragmentTypes: 'inline' },
+        { outputFile: '' }
+      );
+      expect(result.content).toBeSimilarStringTo(`
+        export type Unnamed_1_QueryVariables = Exact<{ [key: string]: never; }>;
+
+
+        export type Unnamed_1_Query = { __typename?: 'Query', me?: { __typename?: 'User', id: string } | null };
+
+        export type UserFragmentFragment = { __typename?: 'User', id: string };
+      `);
+    });
+
+    it("'mask' yields correct types", async () => {
+      const ast = parse(/* GraphQL */ `
+        query {
+          me {
+            ...UserFragment
+          }
+        }
+        fragment UserFragment on User {
+          id
+        }
+      `);
+      const result = await plugin(
+        schema,
+        [{ location: 'test-file.ts', document: ast }],
+        { inlineFragmentTypes: 'mask' },
+        { outputFile: '' }
+      );
+      expect(result.content).toBeSimilarStringTo(`
+        export type Unnamed_1_QueryVariables = Exact<{ [key: string]: never; }>;
+
+
+        export type Unnamed_1_Query = { __typename?: 'Query', me?: (
+            { __typename?: 'User' }
+            & { ' $fragmentRefs': { 'UserFragmentFragment': UserFragmentFragment } }
+          ) | null };
+
+        export type UserFragmentFragment = { __typename?: 'User', id: string } & { ' $fragmentName': 'UserFragmentFragment' };
+      `);
+    });
+  });
 });