fix: use maybeValue with preResolveTypes: true fix (#6951)

* use maybeValue if confifgured

* dev-tests update

* changeset

* default maybeValue fix

* further fix + tests+examples update

* further fix

* fragment inner fields become optional

* dev tests update

* dev tests update

* minor fix

* another minor fix

Author: gilgardosh

.changeset/little-camels-collect.md

@@ -0,0 +1,6 @@
+---
+'@graphql-codegen/visitor-plugin-common': patch
+'@graphql-codegen/typescript-operations': patch
+---
+
+Use maybeValue as default output for optionals on preResolveTypes: true

dev-test/githunt/types.avoidOptionals.ts

@@ -172,13 +172,16 @@ export type OnCommentAddedSubscriptionVariables = Exact<{
 
 export type OnCommentAddedSubscription = {
   __typename?: 'Subscription';
-  commentAdded: {
-    __typename?: 'Comment';
-    id: number;
-    createdAt: number;
-    content: string;
-    postedBy: { __typename?: 'User'; login: string; html_url: string };
-  } | null;
+  commentAdded:
+    | {
+        __typename?: 'Comment';
+        id: number;
+        createdAt: number;
+        content: string;
+        postedBy: { __typename?: 'User'; login: string; html_url: string };
+      }
+    | null
+    | undefined;
 };
 
 export type CommentQueryVariables = Exact<{
@@ -189,29 +192,36 @@ export type CommentQueryVariables = Exact<{
 
 export type CommentQuery = {
   __typename?: 'Query';
-  currentUser: { __typename?: 'User'; login: string; html_url: string } | null;
-  entry: {
-    __typename?: 'Entry';
-    id: number;
-    createdAt: number;
-    commentCount: number;
-    postedBy: { __typename?: 'User'; login: string; html_url: string };
-    comments: Array<{
-      __typename?: 'Comment';
-      id: number;
-      createdAt: number;
-      content: string;
-      postedBy: { __typename?: 'User'; login: string; html_url: string };
-    } | null>;
-    repository: {
-      __typename?: 'Repository';
-      description: string | null;
-      open_issues_count: number | null;
-      stargazers_count: number;
-      full_name: string;
-      html_url: string;
-    };
-  } | null;
+  currentUser: { __typename?: 'User'; login: string; html_url: string } | null | undefined;
+  entry:
+    | {
+        __typename?: 'Entry';
+        id: number;
+        createdAt: number;
+        commentCount: number;
+        postedBy: { __typename?: 'User'; login: string; html_url: string };
+        comments: Array<
+          | {
+              __typename?: 'Comment';
+              id: number;
+              createdAt: number;
+              content: string;
+              postedBy: { __typename?: 'User'; login: string; html_url: string };
+            }
+          | null
+          | undefined
+        >;
+        repository: {
+          __typename?: 'Repository';
+          description: string | null | undefined;
+          open_issues_count: number | null | undefined;
+          stargazers_count: number;
+          full_name: string;
+          html_url: string;
+        };
+      }
+    | null
+    | undefined;
 };
 
 export type CommentsPageCommentFragment = {
@@ -226,7 +236,7 @@ export type CurrentUserForProfileQueryVariables = Exact<{ [key: string]: never }
 
 export type CurrentUserForProfileQuery = {
   __typename?: 'Query';
-  currentUser: { __typename?: 'User'; login: string; avatar_url: string } | null;
+  currentUser: { __typename?: 'User'; login: string; avatar_url: string } | null | undefined;
 };
 
 export type FeedEntryFragment = {
@@ -239,10 +249,10 @@ export type FeedEntryFragment = {
     __typename?: 'Repository';
     full_name: string;
     html_url: string;
-    description: string | null;
+    description: string | null | undefined;
     stargazers_count: number;
-    open_issues_count: number | null;
-    owner: { __typename?: 'User'; avatar_url: string } | null;
+    open_issues_count: number | null | undefined;
+    owner: { __typename?: 'User'; avatar_url: string } | null | undefined;
   };
   vote: { __typename?: 'Vote'; vote_value: number };
   postedBy: { __typename?: 'User'; html_url: string; login: string };
@@ -256,25 +266,32 @@ export type FeedQueryVariables = Exact<{
 
 export type FeedQuery = {
   __typename?: 'Query';
-  currentUser: { __typename?: 'User'; login: string } | null;
-  feed: Array<{
-    __typename?: 'Entry';
-    id: number;
-    commentCount: number;
-    score: number;
-    createdAt: number;
-    repository: {
-      __typename?: 'Repository';
-      full_name: string;
-      html_url: string;
-      description: string | null;
-      stargazers_count: number;
-      open_issues_count: number | null;
-      owner: { __typename?: 'User'; avatar_url: string } | null;
-    };
-    vote: { __typename?: 'Vote'; vote_value: number };
-    postedBy: { __typename?: 'User'; html_url: string; login: string };
-  } | null> | null;
+  currentUser: { __typename?: 'User'; login: string } | null | undefined;
+  feed:
+    | Array<
+        | {
+            __typename?: 'Entry';
+            id: number;
+            commentCount: number;
+            score: number;
+            createdAt: number;
+            repository: {
+              __typename?: 'Repository';
+              full_name: string;
+              html_url: string;
+              description: string | null | undefined;
+              stargazers_count: number;
+              open_issues_count: number | null | undefined;
+              owner: { __typename?: 'User'; avatar_url: string } | null | undefined;
+            };
+            vote: { __typename?: 'Vote'; vote_value: number };
+            postedBy: { __typename?: 'User'; html_url: string; login: string };
+          }
+        | null
+        | undefined
+      >
+    | null
+    | undefined;
 };
 
 export type SubmitRepositoryMutationVariables = Exact<{
@@ -283,17 +300,17 @@ export type SubmitRepositoryMutationVariables = Exact<{
 
 export type SubmitRepositoryMutation = {
   __typename?: 'Mutation';
-  submitRepository: { __typename?: 'Entry'; createdAt: number } | null;
+  submitRepository: { __typename?: 'Entry'; createdAt: number } | null | undefined;
 };
 
 export type RepoInfoFragment = {
   __typename?: 'Entry';
   createdAt: number;
   repository: {
     __typename?: 'Repository';
-    description: string | null;
+    description: string | null | undefined;
     stargazers_count: number;
-    open_issues_count: number | null;
+    open_issues_count: number | null | undefined;
   };
   postedBy: { __typename?: 'User'; html_url: string; login: string };
 };
@@ -305,13 +322,16 @@ export type SubmitCommentMutationVariables = Exact<{
 
 export type SubmitCommentMutation = {
   __typename?: 'Mutation';
-  submitComment: {
-    __typename?: 'Comment';
-    id: number;
-    createdAt: number;
-    content: string;
-    postedBy: { __typename?: 'User'; login: string; html_url: string };
-  } | null;
+  submitComment:
+    | {
+        __typename?: 'Comment';
+        id: number;
+        createdAt: number;
+        content: string;
+        postedBy: { __typename?: 'User'; login: string; html_url: string };
+      }
+    | null
+    | undefined;
 };
 
 export type VoteButtonsFragment = {
@@ -327,5 +347,8 @@ export type VoteMutationVariables = Exact<{
 
 export type VoteMutation = {
   __typename?: 'Mutation';
-  vote: { __typename?: 'Entry'; score: number; id: number; vote: { __typename?: 'Vote'; vote_value: number } } | null;
+  vote:
+    | { __typename?: 'Entry'; score: number; id: number; vote: { __typename?: 'Vote'; vote_value: number } }
+    | null
+    | undefined;
 };