remove arbitrary response read timeout in kinesis GetRecords #3221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Oct 29, 2025
|
The meat of the issue is your comment here #2752 (comment) Basically we're removing a customization from go v1 that we are not aware is an issue across SDKs. This will fix #2752 since we're removing the custom middleware that is panicking, but it could (maybe, maybe not) have issues of other people having read timeouts as originally reported. Whether that custom middleware is problematic could also be true, but that's not addressed currently. I agree that just increasing the read timeout because we weren't sure what the issue was is not the right call and we should remove the customization, but this could surface other issues that we should be ready to deal with |
wty-Bryant
approved these changes
Oct 29, 2025
Madrigal
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2752.
See above issue for context.