Skip to content

Use constructor signature for class decorators #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcodeIO merged 2 commits into from
Dec 14, 2022
Merged

Use constructor signature for class decorators #2587

dcodeIO merged 2 commits into from
Dec 14, 2022

Conversation

@bullno1
Copy link
Contributor

@bullno1 bullno1 commented Dec 6, 2022 •
edited
Loading

Use constructor signature for @unmanaged and @final instead of Function.
This removes the need to use // @ts-ignore: decorator to suppress error from tsserver (used for code completion) while using the assembly.json config.

Function in assembly is different from portable so a class type signature inferred by Typescript is not assignable to Function.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file
@dcodeIO dcodeIO merged commit 1d0451a into AssemblyScript:main Dec 14, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Dec 14, 2022

Thanks!
@bullno1 bullno1 deleted the decorator-decl branch December 15, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@bullno1 @dcodeIO