[tools] go/analysis/passes/modernize: disable BLoop analyzer

1 view

Skip to first unread message

Alan Donovan (Gerrit)

unread,

Dec 22, 2025, 10:01:45 PM (9 days ago) 12/22/25

to Madeline Kalil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, golang-co...@googlegroups.com

Alan Donovan submitted the change

Change information

Commit message:

go/analysis/passes/modernize: disable BLoop analyzer

When b.N is used to benchmark very small workloads,
the suggestion to use b.Loop may result in an increased
overhead that skews benchmark results. Since we cannot
accurately identify such workloads, we unfortunately
should just disable the b.Loop modernizer in the "go
fix" suite.

We leave the modernize enabled in gopls because
it is interactive and programmers will scrutinize
the edits.

Fixes golang/go#74967

Change-Id: I011a167feb865fee6a61cf611aeecb70b285f255

Reviewed-on: https://go-review.googlesource.com/c/tools/+/731962

Commit-Queue: Alan Donovan <adon...@google.com>

Reviewed-by: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Alan Donovan <adon...@google.com>

Files:

M go/analysis/passes/modernize/doc.go
M go/analysis/passes/modernize/modernize.go
M gopls/doc/analyzers.md
M gopls/internal/doc/api.json

Change size: S

Delta: 4 files changed, 6 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Cherry Mui (Gerrit)

unread,

Dec 29, 2025, 7:04:04 PM (2 days ago) 12/29/25

to Madeline Kalil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Alan Donovan, Go LUCI, golang-co...@googlegroups.com

Cherry Mui submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.