[go] simd/archsimd: add punctuations to documentation of emulated ops

0 views
Skip to first unread message

Cherry Mui (Gerrit)

unread,
Dec 30, 2025, 5:04:59 PM (2 days ago) 12/30/25
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, David Chase, golang-co...@googlegroups.com

Cherry Mui submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/simd/archsimd/ops_amd64.go
Insertions: 6, Deletions: 6.

@@ -5687,37 +5687,37 @@
/* Scale */

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPS, CPU Feature: AVX512
func (x Float32x4) Scale(y Float32x4) Float32x4

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPS, CPU Feature: AVX512
func (x Float32x8) Scale(y Float32x8) Float32x8

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPS, CPU Feature: AVX512
func (x Float32x16) Scale(y Float32x16) Float32x16

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPD, CPU Feature: AVX512
func (x Float64x2) Scale(y Float64x2) Float64x2

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPD, CPU Feature: AVX512
func (x Float64x4) Scale(y Float64x4) Float64x4

// Scale multiplies each element of x by 2 raised to the power of the
-// corresponding element in y.
+// floor of the corresponding element in y.
//
// Asm: VSCALEFPD, CPU Feature: AVX512
func (x Float64x8) Scale(y Float64x8) Float64x8
```
```
The name of the file: src/simd/archsimd/_gen/simdgen/ops/FPonlyArith/categories.yaml
Insertions: 1, Deletions: 1.

@@ -19,7 +19,7 @@
commutative: false
documentation: !string |-
// NAME multiplies each element of x by 2 raised to the power of the
- // corresponding element in y.
+ // floor of the corresponding element in y.
- go: RoundToEven
commutative: false
constImm: 0
```

Change information

Commit message:
simd/archsimd: adjust documentations slightly

- Reword the documentation of Scale to mention parameter names.
- Correct the parameter name in Merge.
- Use proper a/an articles in some documentation.
- Add punctuations.
- Format code blocks for long expressions.
Change-Id: I8a31721503c1b155862255619a835895f3d5123a
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
  • M src/simd/archsimd/_gen/simdgen/ops/FPonlyArith/categories.yaml
  • M src/simd/archsimd/_gen/simdgen/ops/Moves/categories.yaml
  • M src/simd/archsimd/_gen/simdgen/ops/Moves/go.yaml
  • M src/simd/archsimd/_gen/tmplgen/main.go
  • M src/simd/archsimd/compare_gen_amd64.go
  • M src/simd/archsimd/extra_amd64.go
  • M src/simd/archsimd/maskmerge_gen_amd64.go
  • M src/simd/archsimd/ops_amd64.go
  • M src/simd/archsimd/ops_internal_amd64.go
  • M src/simd/archsimd/other_gen_amd64.go
  • M src/simd/archsimd/shuffles_amd64.go
  • M src/simd/archsimd/slice_gen_amd64.go
  • M src/simd/archsimd/types_amd64.go
Change size: XL
Delta: 14 files changed, 897 insertions(+), 719 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I8a31721503c1b155862255619a835895f3d5123a
Gerrit-Change-Number: 731560
Gerrit-PatchSet: 4
Gerrit-Owner: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages