[go] test/codegen: fix a tab in comparisons.go to ensure pattern works

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Dec 30, 2025, 10:28:54 AM (2 days ago) 12/30/25

to Alexander Musman, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Go LUCI, Keith Randall, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

test/codegen: fix a tab in comparisons.go to ensure pattern works

Fix a pattern in test/codegen/comparisons.go to use whitespace instead
of a tab. The test needs a whitespace to properly fail if the regalloc
change from CL686655 would be missing (in that case we would have a
spill immediately after call to memequal, which is supposed to be
captured by this pattern).

Change-Id: I5b6fb5e861b9327c7f071660592b8ffa265e0030

Reviewed-on: https://go-review.googlesource.com/c/go/+/727620

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-by: Cherry Mui <cher...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Keith Randall <k...@golang.org>

Reviewed-by: Keith Randall <k...@google.com>

Files:

M test/codegen/comparisons.go

Change size: XS

Delta: 1 file changed, 2 insertions(+), 2 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Keith Randall, +1 by Keith Randall, +1 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages