Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 811046: code review 811046: rpc: abstract client and server encodings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by rsc
Modified:
15 years, 8 months ago
Reviewers:
CC:
r, golang-dev, rog
Visibility:
Public.

Description

rpc: abstract client and server encodings

Patch Set 1 #

Patch Set 2 : code review 811046: rpc: abstract client and server encodings #

Total comments: 4

Patch Set 3 : code review 811046: rpc: abstract client and server encodings #

Patch Set 4 : code review 811046: rpc: abstract client and server encodings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -41 lines) Patch
M src/pkg/rpc/client.go View 1 2 6 chunks +56 lines, -14 lines 0 comments Download
M src/pkg/rpc/server.go View 1 2 3 8 chunks +75 lines, -27 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 8 months ago (2010-04-25 23:41:25 UTC) #1
rsc
I'm not thrilled with the interface names. Suggestions welcome.
15 years, 8 months ago (2010-04-25 23:42:08 UTC) #2
rog
http://codereview.appspot.com/811046/diff/2001/3001 File src/pkg/rpc/client.go (right): http://codereview.appspot.com/811046/diff/2001/3001#newcode42 src/pkg/rpc/client.go:42: // reading of RPC responses for the server side ...
15 years, 8 months ago (2010-04-26 07:16:40 UTC) #3
adg1
ServerEncoder / ClientEncoder ? Seems more consistent with Reader/Writer, and with the concept of an ...
15 years, 8 months ago (2010-04-26 07:33:27 UTC) #4
r
i didn't mark all the name changes but you should see what i'm suggesting. http://codereview.appspot.com/811046/diff/2001/3001 ...
15 years, 8 months ago (2010-04-26 18:49:12 UTC) #5
rsc
Hello r (cc: golang-dev@googlegroups.com, rog), Please take another look.
15 years, 8 months ago (2010-04-27 18:31:03 UTC) #6
r
LGTM names are much clearer
15 years, 8 months ago (2010-04-27 18:33:11 UTC) #7
rsc
15 years, 8 months ago (2010-04-27 20:51:28 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=9daf796ebf1c ***

rpc: abstract client and server encodings

R=r
CC=golang-dev, rog
http://codereview.appspot.com/811046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b