code review 811046: rpc: abstract client and server encodings

rpc: abstract client and server encodings

[rsc, 2010-04-25 23:41:25]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-04-25 23:42:08]

I'm not thrilled with the interface names.
Suggestions welcome.

[rog, 2010-04-26 07:16:40]

http://codereview.appspot.com/811046/diff/2001/3001
File src/pkg/rpc/client.go (right):

http://codereview.appspot.com/811046/diff/2001/3001#newcode42
src/pkg/rpc/client.go:42: // reading of RPC responses for the server side of an
RPC session.
s/server/client/ ?

[adg1, 2010-04-26 07:33:27]

ServerEncoder / ClientEncoder ?

Seems more consistent with Reader/Writer, and with the concept of an
interface being something that _does_ something.

On 26 April 2010 09:42, Russ Cox <rsc@golang.org> wrote:
> I'm not thrilled with the interface names.
> Suggestions welcome.
>
>
> --
> Subscription settings:
http://groups.google.com/group/golang-dev/subscribe?hl=en
>

[r, 2010-04-26 18:49:12]

i didn't mark all the name changes but you should see what i'm suggesting.

http://codereview.appspot.com/811046/diff/2001/3001
File src/pkg/rpc/client.go (right):

http://codereview.appspot.com/811046/diff/2001/3001#newcode42
src/pkg/rpc/client.go:42: // reading of RPC responses for the server side of an
RPC session.
the name is indeed odd, and the comment is wrong as rog says.
plus it encodes and decodes.
i suggest calling this a ClientCodec and the other a ServerCodec

http://codereview.appspot.com/811046/diff/2001/3001#newcode128
src/pkg/rpc/client.go:128: func NewClientEncoding(enc ClientEncoding) *Client {
NewClientWithCodec

without "With" it doesn't read like what it means.

http://codereview.appspot.com/811046/diff/2001/3001#newcode141
src/pkg/rpc/client.go:141: type gobClientEncoding struct {
and Codec here etc.

[rsc, 2010-04-27 18:31:03]

Hello r (cc: golang-dev@googlegroups.com, rog),

Please take another look.

[r, 2010-04-27 18:33:11]

LGTM

names are much clearer

[rsc, 2010-04-27 20:51:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=9daf796ebf1c ***

rpc: abstract client and server encodings

R=r
CC=golang-dev, rog
http://codereview.appspot.com/811046