First ydb-go-sdk generation version (See #4) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort .Query(...) syntax
…er instead of database/sql
kprokopenko
reviewed
Aug 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kprokopenko
approved these changes
Sep 2, 2025
…sultSet(...). + Refactored some test examples
There was a problem hiding this comment.
Pull Request Overview
This PR adds native YDB Go SDK support to sqlc for YDB database engine, moving from the standard database/sql interface to the YDB-specific SDK. The implementation includes code generation templates, configuration updates, and example adaptations.
- Adds YDB Go SDK as a new SQL package option (
ydb-go-sdk) - Implements YDB-specific code generation templates for queries, interfaces, and database connections
- Updates configuration schema to support YDB as an engine option
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/sqltest/local/ydb.go | Refactored YDB test setup to use native YDB SDK instead of database/sql |
| internal/config/v_two.json | Added "ydb" as a valid database engine option |
| internal/codegen/golang/templates/ydb-go-sdk/* | New YDB-specific code generation templates for queries, interfaces, and database code |
| internal/codegen/golang/templates/template.tmpl | Integrated YDB template conditions into main template |
| internal/codegen/golang/query.go | Added YDB parameter mapping functionality |
| internal/codegen/golang/opts/enum.go | Added YDB Go SDK package and driver constants |
| internal/codegen/golang/imports.go | Added YDB-specific import handling |
| internal/codegen/golang/gen.go | Added validation for unsupported YDB commands |
| internal/codegen/golang/driver.go | Added YDB driver parsing support |
| go.mod | Updated YDB Go SDK version |
| examples/authors/ydb/* | Updated example to use new YDB Go SDK interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1NepuNep1
added a commit
that referenced
this pull request
Sep 3, 2025
This PR adds native YDB Go SDK support to sqlc for YDB database engine, moving from the standard database/sql interface to the YDB-specific SDK. The implementation includes code generation templates, configuration updates, and example adaptations. Adds YDB Go SDK as a new SQL package option (ydb-go-sdk) Implements YDB-specific code generation templates for queries, interfaces, and database connections Updates configuration schema to support YDB as an engine option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See (#4)
Added native ydb-go-sdk generation support for YDB engine. Supported :queryrows comment to add support for
.Query(...)method.