Don't throw chrome.runtime.lastError by default

Author: Ke, Mingze

chrome-app/eventPage.js

@@ -134,10 +134,8 @@
   function removeListener(objName, portName, id) {
     if (listenerMap[objName]) {
       if (typeof id === 'undefined') {
-        listenerMap[objName].receivers.forEach(function (receiver, idx) {
-          if (receiver.portName === portName) {
-            listenerMap[objName].receivers.splice(idx, 1);
-          }
+        listenerMap[objName].receivers = listenerMap[objName].receivers.filter(function (receiver) {
+          return receiver.portName !== portName;
         });
       } else {
         listenerMap[objName].receivers.some(function (receiver, idx) {

chrome-app/manifest.json

@@ -1,6 +1,6 @@
 {
   "name": "API Proxy for Google Chrome™",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "manifest_version": 2,
   "minimum_chrome_version": "23",
   "app": {

lib/chrome._api.js

@@ -46,6 +46,7 @@ chrome._api = (function (window) {
   }
 
   function invoke(id, method, params) {
+    delete chrome.runtime.lastError;
     window.postMessage({
       jsonrpc: '2.0',
       id: id,
@@ -59,14 +60,16 @@ chrome._api = (function (window) {
 
     if (msg.jsonrpc && !msg.method) {
       if (msg.error) {
-        throw msg.error;
-      } else if (msg.result) {
-        if (callbackHash[msg.id]) {
-          callbackHash[msg.id].apply(undef, msg.result);
-          delete callbackHash[msg.id];
-        } else if (listenerHash[msg.id]) {
-          listenerHash[msg.id].apply(undef, msg.result);
-        }
+        chrome.runtime.lastError = {
+          message: msg.error
+        };
+      }
+
+      if (callbackHash[msg.id]) {
+        callbackHash[msg.id].apply(undef, msg.result);
+        delete callbackHash[msg.id];
+      } else if (listenerHash[msg.id]) {
+        listenerHash[msg.id].apply(undef, msg.result);
       }
     }
   }, false);
@@ -78,3 +81,5 @@ chrome._api = (function (window) {
   };
 
 }(window));
+
+chrome.runtime = chrome.runtime || {};