Fix: Properly encode label URLs with spaces in both API and page links #5338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encoding for labels with spaces in fetchIssueCount.jsUpdate fetchIssueCount.js Wrap labels containing spaces in double quotes before URL encoding to prevent API request failures. This fixes issue where labels with spaces (like 'good first issue') would not work properly when fetching issue counts from the GitHub API.
…or labels with spaces in templateUpdate scripts.html Updated the HTML template to properly encode GitHub label URLs when labels contain spaces by wrapping them in double quotes before URL encoding. This fixes the bug where labels with spaces would result in broken links to GitHub issues pages. The fix mirrors the same encoding logic that was already applied in fetchIssueCount.js.
✅ Deploy Preview for up-for-grabs-test-bench ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under As you make changes to this pull request, I'll re-run these checks. |
…-for-grabs#912)Improve accessibility: fix heading hierarchy in before.html (Fixes up-for-grabs#912)Update before.html - Changed h1 to h2 for proper heading hierarchy - Added h3 for subsection heading - Added semantic section with aria-labelledby - Changed ul to ol for numbered steps - Added explicit role='list' for better screen reader support
…bs#912)Update index.html - Added proper semantic structure with main element - Added aria-labelledby attributes for better screen reader support - Added role='region' and aria-label for projects panel - Improved heading structure and navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the bug reported in issue #5239 where labels containing spaces cause broken GitHub URLs in both the website interface and API requests.
Changes Made
1. Fixed API Requests (
javascripts/fetchIssueCount.js)2. Fixed Page Links (
_includes/scripts.html)Technical Details
Before: Labels like "good first issue" would generate malformed URLs:
https://api.github.com/repos/owner/repo/issues?labels=good first issuehttps://github.com/owner/repo/labels/good first issueAfter: Labels are properly encoded:
https://api.github.com/repos/owner/repo/issues?labels="good%20first%20issue"https://github.com/owner/repo/labels/good%20first%20issueTesting
Tested with projects that have labels containing spaces to ensure:
Fixes #5239