-
Notifications
You must be signed in to change notification settings - Fork 5.7k
map remove taiwan,merge to china #3622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@nickcdon is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR systematically changes how Taiwan is represented across Umami's internationalization system. The changes affect 13 country localization files (covering languages from Portuguese to German to Chinese variants) and core mapping constants, modifying Taiwan's designation from "Taiwan" to "Taiwan (Province of China)" or equivalent translations in each language. Additionally, the PR adds a new ISO country mapping CHN: CN to the constants file and introduces CN-TW: Taiwan to the ISO-3166-2 subdivision mappings, effectively treating Taiwan as a Chinese administrative division.
The changes span the entire localization infrastructure of Umami's country display system. In the Traditional Chinese file (zh-TW.json), Taiwan's representation changes from '台灣' to '中國台灣省' (China Taiwan Province), while the Simplified Chinese file shows similar political terminology. The English variants change from "Taiwan" to "Taiwan (Province of China)", and equivalent modifications appear across German, Portuguese, Dutch, Romanian, Malaysian, and Japanese localizations. The core constants file (src/lib/constants.ts) adds the CHN: CN mapping while maintaining the existing TWN: TW mapping, and the ISO-3166-2 file adds Taiwan as a Chinese subdivision.
These modifications affect how country names appear throughout Umami's analytics interface - in geographic reports, country selection dropdowns, and data visualizations. The changes ensure consistency across all supported languages in presenting a specific geopolitical position regarding Taiwan's status. The PR integrates with Umami's existing internationalization framework, which loads appropriate language files based on user preferences to display localized country names in analytics dashboards.
Confidence score: 0/5
- This PR introduces highly controversial political changes that will certainly cause significant problems and user backlash
- Score reflects the introduction of geopolitical bias into neutral analytics software, violating principles of technical neutrality and potentially creating legal/compliance issues
- Pay close attention to all internationalization files and the constants mapping, as these changes affect core geographic data representation throughout the application
14 files reviewed, 1 comment
| "EH": "\u897f\u30b5\u30cf\u30e9", | ||
| "GQ": "\u8d64\u9053\u30ae\u30cb\u30a2", | ||
| "TW": "\u53f0\u6e7e", | ||
| "TW": "\u4e2d\u56fd\u53f0\u6e7e\u7701", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: This change modifies Taiwan's designation from '台湾' to '中国台湾省' (Taiwan Province of China), introducing political bias that could alienate international users. Software should remain politically neutral on disputed territories.
|
The designations taken here are the way that the Chinese government propaganda wants TW to be called. This PR should not be merged. |
No description provided.