-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Dropdown menu #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dropdown menu #3605
Conversation
|
@chrismuto is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR makes several changes that appear to be split between the stated purpose of adding dropdown scrolling and unrelated modifications. The primary feature adds scrolling functionality to the WebsiteSelect dropdown component by applying Tailwind CSS classes (h-72 overflow-y-auto) to constrain the dropdown height to 288px and enable vertical scrolling when users have many websites.
However, the PR also includes extensive rebranding changes throughout the application, changing "umami" to "Triton" in multiple components (AppLayout, Header, NavBar). The application title becomes "Triton Analytics", navigation links point to tritoncg.com, and the logo reference changes from logo.svg to icon.svg. Additionally, the PR includes routine dependency updates across package.json, updating packages like date-fns, react-spring, and eslint to newer versions.
Other configuration changes include modifying the Prettier configuration to use "auto" line endings instead of enforcing Unix-style line endings. Most concerning is the complete removal of the .husky/pre-commit file, which eliminates the automatic linting process that was running on staged files before commits. There's also an incomplete Docker configuration change that copies pnpm-lock.yaml while continuing to use yarn commands throughout the Dockerfile.
The dropdown scrolling functionality integrates well with the existing codebase architecture, following established patterns where className props are passed to react-basics Dropdown components. The rebranding changes maintain all existing functionality while updating visual identity elements.
Confidence score: 2/5
- This PR contains critical issues that make it unsafe to merge, particularly the removal of code quality gates and incomplete package manager migration
- Score reflects the presence of blocking issues including the deleted pre-commit hook and inconsistent Docker configuration that will cause build failures
- Pay close attention to the Dockerfile and consider restoring the
.husky/pre-commitfile to maintain code quality standards
9 files reviewed, 2 comments
| COPY package.json pnpm-lock.yaml ./ | ||
| # Add yarn timeout to handle slow CPU when Github Actions | ||
| RUN yarn config set network-timeout 300000 | ||
| RUN yarn install --frozen-lockfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Critical inconsistency: copying pnpm-lock.yaml but using yarn commands will cause build failure. Either revert to yarn.lock or update all yarn commands to use pnpm.
| COPY package.json pnpm-lock.yaml ./ | |
| # Add yarn timeout to handle slow CPU when Github Actions | |
| RUN yarn config set network-timeout 300000 | |
| RUN yarn install --frozen-lockfile | |
| COPY package.json yarn.lock ./ | |
| # Add yarn timeout to handle slow CPU when Github Actions | |
| RUN yarn config set network-timeout 300000 | |
| RUN yarn install --frozen-lockfile |
| { | ||
| "arrowParens": "avoid", | ||
| "endOfLine": "lf", | ||
| "endOfLine": "auto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Changing from 'lf' to 'auto' can cause inconsistent line endings across the team. Consider keeping 'lf' for consistency, especially since the project already had this standard.
added scrolling for website select dropdown menu