feat: add events page filters #3418
Open
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PirvuCatalin is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds filtering capabilities to the events page, implementing custom event filtering functionality that was previously available before the Events redesign.
- Added
FilterTagscomponent in/events/EventsPage.tsxto display and manage active filters with editable filter tags - Implemented filter parameter extraction from URL query using
FILTER_COLUMNSconstant inEventsPage.tsx - Added
WebsiteFilterButtontoEventsMetricsBar.tsxwith conditional rendering based onshowFilterprop - Enhanced SQL queries in
getWebsiteEvents.tsto support filtering by adding filter conditions to both relational and clickhouse queries
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| import EventProperties from './EventProperties'; | ||
| import { FILTER_COLUMNS } from '@/lib/constants'; | ||
|
|
||
| export default function EventsPage({ websiteId }) { |
There was a problem hiding this comment.
style: Missing TypeScript type for websiteId prop
Suggested change
| export default function EventsPage({ websiteId }) { | |
| export default function EventsPage({ websiteId }: { websiteId: string }) { |
|
fyi @mikecao |
|
Hope it will be soon released |
|
Would also love to see this merged! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't check the rules for contributing, but I will :/
This solves #2977