fix(extensions/table-of-content): IME capture Error #7134
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add compositionstart handler to undo input rules when IME starts - Prevent input rules from interfering with IME text composition - Maintain existing compositionend behavior for rule application
- Delete compositionstart event handler that was interfering with IME input - Keep compositionend handler for proper text input rule processing - Maintain undoInputRule functionality through other means
- Prevent table of contents plugin from updating during input method editor composition - Add composition checks in both plugin transaction handler and extension transaction handler - Avoid interfering with IME input by skipping unnecessary TOC updates
…oid interference with input.
🦋 Changeset detectedLatest commit: 42b9fc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 70 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with Chinese IME (Input Method Editor) input by preventing table of contents updates during IME composition. The fix adds a check to skip table of contents updates when IME composition is in progress, avoiding interference with the input method editor.
Key Changes:
- Added IME composition detection to skip table of contents updates during composition
- Included a changeset documenting the patch fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/extension-table-of-contents/src/plugin.ts | Added guard to skip table of contents updates during IME composition |
| .changeset/plenty-dancers-listen.md | Added changeset documenting the IME fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Skip IME compositing when calling
appendTransaction.Implementation Approach
Skip IME compositing when calling
appendTransaction.Testing Done
pnpm devVerification Steps
pnpm devTable Of ContentdemoAdditional Notes
Checklist
Related Issues
Fixes: #7126