Skip to content

Commit 03d9639

Browse files
test(eslint-plugin): add extra tests (#10587)
* test(eslint-plugin): add extra tests Adds a couple of extra test cases for these rules: - `class-methods-use-this` - `consistent-type-assertions` - `no-array-delete` * test: update no-array-delete test to remove comment Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
1 parent e697cfa commit 03d9639

File tree

3 files changed

+54
-0
lines changed

3 files changed

+54
-0
lines changed

‎packages/eslint-plugin/tests/rules/class-methods-use-this/class-methods-use-this.test.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,22 @@ class Foo implements Bar {
549549
},
550550
],
551551
},
552+
{
553+
code: `
554+
function fn() {
555+
this.foo = 303;
556+
557+
class Foo {
558+
method() {}
559+
}
560+
}
561+
`,
562+
errors: [
563+
{
564+
messageId: 'missingThis',
565+
},
566+
],
567+
},
552568
],
553569
valid: [
554570
{

‎packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,18 @@ ruleTester.run('consistent-type-assertions', rule, {
157157
},
158158
},
159159
},
160+
{
161+
code: `
162+
const x = { key: 'value' } as any;
163+
`,
164+
options: [{ assertionStyle: 'as', objectLiteralTypeAssertions: 'never' }],
165+
},
166+
{
167+
code: `
168+
const x = { key: 'value' } as unknown;
169+
`,
170+
options: [{ assertionStyle: 'as', objectLiteralTypeAssertions: 'never' }],
171+
},
160172
],
161173
invalid: [
162174
...dedupeTestCases(

‎packages/eslint-plugin/tests/rules/no-array-delete.test.ts

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ ruleTester.run('no-array-delete', rule, {
5555
declare const test: never;
5656
delete test[0];
5757
`,
58+
`
59+
delete console.log();
60+
`,
5861
],
5962

6063
invalid: [
@@ -596,5 +599,28 @@ ruleTester.run('no-array-delete', rule, {
596599
},
597600
],
598601
},
602+
{
603+
code: `
604+
declare const arr: string & Array<number>;
605+
delete arr[0];
606+
`,
607+
errors: [
608+
{
609+
column: 9,
610+
endColumn: 22,
611+
line: 3,
612+
messageId: 'noArrayDelete',
613+
suggestions: [
614+
{
615+
messageId: 'useSplice',
616+
output: `
617+
declare const arr: string & Array<number>;
618+
arr.splice(0, 1);
619+
`,
620+
},
621+
],
622+
},
623+
],
624+
},
599625
],
600626
});

0 commit comments

Comments
 (0)