-
Notifications
You must be signed in to change notification settings - Fork 432
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
See this run: https://github.com/tursodatabase/libsql/actions/runs/18771985804/job/53558192484?pr=2176
which does:
cd libsql-sqlite3/test/rust_suite
# Only execute extensions tests
cargo test --features=extensions extensions
but it fails with:
error: rustc 1.85.0 is not supported by the following package:
home@0.5.12 requires rustc 1.88
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.85.0
(The project's rust version is 1.85)
It fails because rust_suite does not have Cargo.lock (🤦) so everytime it tries to fetch latest version of home and thus causing issues.
I downgraded the home version, but it breaks in other ways:
error: failed to run custom build command for `wabt-sys v0.8.0`
Caused by:
process didn't exit successfully: `/Users/avi/turso/libsql/libsql-sqlite3/test/rust_suite/target/debug/build/wabt-sys-b5d7a0ad6232b6c6/build-script-build` (exit status: 101)
--- stdout
cargo:rerun-if-env-changed=WABT_CXXSTDLIB
cargo:rerun-if-env-changed=CXXSTDLIB
CMAKE_TOOLCHAIN_FILE_aarch64-apple-darwin = None
CMAKE_TOOLCHAIN_FILE_aarch64_apple_darwin = None
HOST_CMAKE_TOOLCHAIN_FILE = None
CMAKE_TOOLCHAIN_FILE = None
CMAKE_GENERATOR_aarch64-apple-darwin = None
CMAKE_GENERATOR_aarch64_apple_darwin = None
HOST_CMAKE_GENERATOR = None
CMAKE_GENERATOR = None
CMAKE_PREFIX_PATH_aarch64-apple-darwin = None
CMAKE_PREFIX_PATH_aarch64_apple_darwin = None
HOST_CMAKE_PREFIX_PATH = None
CMAKE_PREFIX_PATH = None
CMAKE_aarch64-apple-darwin = None
CMAKE_aarch64_apple_darwin = None
HOST_CMAKE = None
CMAKE = None
running: cd "/Users/avi/turso/libsql/libsql-sqlite3/test/rust_suite/target/debug/build/wabt-sys-78ba8435bc772e41/out/build" && CMAKE_PREFIX_PATH="" LC_ALL="C" "cmake" "/Users/avi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wabt-sys-0.8.0/wabt" "-DCMAKE_OSX_ARCHITECTURES=arm64" "-DBUILD_TESTS=OFF" "-DBUILD_TOOLS=OFF" "-DCMAKE_INSTALL_PREFIX=/Users/avi/turso/libsql/libsql-sqlite3/test/rust_suite/target/debug/build/wabt-sys-78ba8435bc772e41/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-macosx -mmacosx-version-min=15.5" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-macosx -mmacosx-version-min=15.5" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-macosx -mmacosx-version-min=15.5" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug"
-- Configuring incomplete, errors occurred!
--- stderr
CMake Error at CMakeLists.txt:17 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
thread 'main' panicked at /Users/avi/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cmake-0.1.54/src/lib.rs:1119:5:
command did not execute successfully, got: exit status: 1
build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
I don;t think messing with Rust version or Cmake is a right way. Rather we need to find the versions of home and wabt which just works™️
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed