Skip to content

Conversation

@GuyLewin
Copy link

@GuyLewin GuyLewin commented Jul 3, 2023

Fixes #511

Signed-off-by: GuyLewin <Guy@lewin.co.il>
Signed-off-by: GuyLewin <Guy@lewin.co.il>
Signed-off-by: GuyLewin <Guy@lewin.co.il>
@GuyLewin
Copy link
Author

GuyLewin commented Jul 4, 2023

@BusyJay do you agree with my change in src/storage.rs?:

raft-rs/src/storage.rs

Lines 422 to 423 in b0a3740

// Initialize term with a valid value (anything except 0)
core.raft_state.hard_state.term = 1;
?

If so - it breaks a lot of tests but I can go over them and fix them. I just don't want to do it if it's the incorrect fix since it'll require some manual work.

@BusyJay
Copy link
Member

BusyJay commented Jul 5, 2023

MemStorage is supposed to be used for tests, change it or not are OK to me.

@tisonkun tisonkun self-requested a review July 5, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants