Skip to content

🔧 Update mypy config, use strict = true instead of manual configs #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 3 commits into from
Oct 23, 2023
Merged

🔧 Update mypy config, use strict = true instead of manual configs #428

tiangolo merged 3 commits into from
Oct 23, 2023
+1 −15

Conversation

@michaeloliverx
Copy link

@michaeloliverx michaeloliverx commented Aug 31, 2022 •
edited
Loading

Analogous to fastapi/fastapi#4605.
@michaeloliverx michaeloliverx changed the title 🔧 Update mypy config, use strict = true instead of manual configs Aug 31, 2022
@michaeloliverx michaeloliverx marked this pull request as ready for review August 31, 2022 13:07
@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (cc6ca53) 97.76%.
Report is 70 commits behind head on main.

❗ Current head cc6ca53 differs from pull request most recent head 5fbaaf5. Consider uploading reports for the commit 5fbaaf5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   98.49%   97.76%   -0.74%     
==========================================
  Files         185      187       +2     
  Lines        5856     6268     +412     
==========================================
+ Hits         5768     6128     +360     
- Misses         88      140      +52

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

📝 Docs preview for commit cc6ca53 at: https://630f5dc38de1a90551a802d0--sqlmodel.netlify.app
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

📝 Docs preview for commit 8e503db at: https://639cfbfbecf1fd184f9b4267--sqlmodel.netlify.app
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

📝 Docs preview for commit 5fbaaf5 at: https://02aa9e28.sqlmodel.pages.dev
@tiangolo tiangolo merged commit 1062e1b into fastapi:main Oct 23, 2023
@tiangolo
Copy link
Member

tiangolo commented Oct 23, 2023

Great, thank you @michaeloliverx! ☕ 🍰
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal

2 participants

@michaeloliverx @tiangolo