Skip to content

Conversation

@onionj
Copy link
Contributor

@onionj onionj commented Oct 3, 2021

Edit code in document (typo)
According to the tutorial I read, this is wrong
In the Hero model, you wrote back_populates as the owner
But in this model, you have written field as hero, change hero to owner..

@tiangolo tiangolo changed the title Edit code in document (typo): tutorial003.py in Weapon owner Field, change hero to owner Aug 27, 2022
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #120 (5cf58ef) into main (006cf48) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5cf58ef differs from pull request most recent head 6085c17. Consider uploading reports for the commit 6085c17 to get more accurate results

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         182      182           
  Lines        6054     6054           
=======================================
  Hits         5908     5908           
  Misses        146      146           
Impacted Files Coverage Δ
...ationship_attributes/back_populates/tutorial003.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tiangolo
Copy link
Member

Good catch, thank you @onionj! 🚀

I updated it to instead use the word hero everywhere. Thanks! ☕

@tiangolo tiangolo enabled auto-merge (squash) August 27, 2022 20:40
@tiangolo tiangolo merged commit d032c3c into fastapi:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants