Skip to content

feat: support deletion of Cloud Asset Inventory feeds not in use in organization #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renato-rudnicki
Copy link
Contributor

@renato-rudnicki renato-rudnicki commented Apr 12, 2024

This PR supports the deletion of Cloud Asset Inventory feeds not in use in organization that match a given pattern

@renato-rudnicki renato-rudnicki requested a review from a team as a code owner April 12, 2024 21:24
@renato-rudnicki renato-rudnicki changed the title feat: support deletion of Cloud Asset Inventory feeds not in use in organization #183 Apr 12, 2024
@renato-rudnicki renato-rudnicki changed the title feat: support deletion of Cloud Asset Inventory feeds not in use in organization #183 Apr 12, 2024
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comment about rebasing on Daniels PR to share some of the code

@daniel-cit
Copy link
Contributor

@bharathkkb @apeabody Build is Green 🟢

@apeabody apeabody merged commit bd8f8ad into terraform-google-modules:master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants