Skip to content

Commit ff0be2f

Browse files
authored
fix: updates for go modules (#184)
1 parent f9b6039 commit ff0be2f

File tree

4 files changed

+75
-18
lines changed

4 files changed

+75
-18
lines changed

‎.github/workflows/go-lint.yaml

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# Copyright 2024 Google LLC
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
name: go-lint
16+
on:
17+
pull_request:
18+
branches:
19+
- master
20+
paths:
21+
- ".github/workflows/go-lint.yaml"
22+
- "modules/project_cleanup/function_source/**"
23+
permissions:
24+
contents: read
25+
26+
concurrency:
27+
group: '$${{ github.workflow }}-$${{ github.head_ref || github.ref }}'
28+
cancel-in-progress: true
29+
30+
jobs:
31+
golangci:
32+
name: ${{ matrix.folder }}
33+
runs-on: ubuntu-latest
34+
strategy:
35+
fail-fast: false
36+
matrix:
37+
folder: [modules/project_cleanup/function_source]
38+
steps:
39+
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
40+
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
41+
with:
42+
go-version-file: ${{ matrix.folder }}/go.mod
43+
cache-dependency-path: ${{ matrix.folder }}/go.sum
44+
- name: golangci-lint
45+
uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
46+
with:
47+
version: latest
48+
working-directory: ${{ matrix.folder }}
49+
args: --timeout=5m

‎.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ credentials.json
77
.vscode/
88
*.pyc
99
.kitchen
10+
go.work.sum
1011

1112
examples/**/*.zip
1213
examples/**/terraform.tfvars

‎go.work

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
go 1.21
2+
3+
use (
4+
./modules/project_cleanup/function_source
5+
./test/integration
6+
)

‎modules/project_cleanup/function_source/main.go

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import (
3434
cloudresourcemanager3 "google.golang.org/api/cloudresourcemanager/v3"
3535
"google.golang.org/api/compute/v1"
3636
"google.golang.org/api/googleapi"
37+
"google.golang.org/api/option"
3738
"google.golang.org/api/servicemanagement/v1"
3839
)
3940

@@ -241,57 +242,57 @@ func getCorrectOrganizationIdOrTerminateExecution() string {
241242
return targetOrganizationIdString
242243
}
243244

244-
func getServiceManagementServiceOrTerminateExecution(client *http.Client) *servicemanagement.APIService {
245-
service, err := servicemanagement.New(client)
245+
func getServiceManagementServiceOrTerminateExecution(ctx context.Context, client *http.Client) *servicemanagement.APIService {
246+
service, err := servicemanagement.NewService(ctx, option.WithHTTPClient(client))
246247
if err != nil {
247248
logger.Fatalf("Failed to get service management API client with error [%s], terminate execution", err.Error())
248249
}
249250
return service
250251
}
251252

252-
func getResourceManagerServiceOrTerminateExecution(client *http.Client) *cloudresourcemanager.Service {
253+
func getResourceManagerServiceOrTerminateExecution(ctx context.Context, client *http.Client) *cloudresourcemanager.Service {
253254
logger.Println("Try to get Cloud Resource Manager")
254-
cloudResourceManagerService, err := cloudresourcemanager.New(client)
255+
cloudResourceManagerService, err := cloudresourcemanager.NewService(ctx, option.WithHTTPClient(client))
255256
if err != nil {
256257
logger.Fatalf("Failed to get Cloud Resource Manager with error [%s], terminate execution", err.Error())
257258
}
258259
logger.Println("Got Cloud Resource Manager")
259260
return cloudResourceManagerService
260261
}
261262

262-
func getFolderServiceOrTerminateExecution(client *http.Client) *cloudresourcemanager2.FoldersService {
263+
func getFolderServiceOrTerminateExecution(ctx context.Context, client *http.Client) *cloudresourcemanager2.FoldersService {
263264
logger.Println("Try to get Folders Service")
264-
cloudResourceManagerService, err := cloudresourcemanager2.New(client)
265+
cloudResourceManagerService, err := cloudresourcemanager2.NewService(ctx, option.WithHTTPClient(client))
265266
if err != nil {
266267
logger.Fatalf("Failed to get Folders Service with error [%s], terminate execution", err.Error())
267268
}
268269
logger.Println("Got Folders Service")
269270
return cloudResourceManagerService.Folders
270271
}
271272

272-
func getTagKeysServiceOrTerminateExecution(client *http.Client) *cloudresourcemanager3.TagKeysService {
273+
func getTagKeysServiceOrTerminateExecution(ctx context.Context, client *http.Client) *cloudresourcemanager3.TagKeysService {
273274
logger.Println("Try to get TagKeys Service")
274-
cloudResourceManagerService, err := cloudresourcemanager3.New(client)
275+
cloudResourceManagerService, err := cloudresourcemanager3.NewService(ctx, option.WithHTTPClient(client))
275276
if err != nil {
276277
logger.Fatalf("Failed to get TagKeys Service with error [%s], terminate execution", err.Error())
277278
}
278279
logger.Println("Got TagKeys Service")
279280
return cloudResourceManagerService.TagKeys
280281
}
281282

282-
func getTagValuesServiceOrTerminateExecution(client *http.Client) *cloudresourcemanager3.TagValuesService {
283+
func getTagValuesServiceOrTerminateExecution(ctx context.Context, client *http.Client) *cloudresourcemanager3.TagValuesService {
283284
logger.Println("Try to get TagValues Service")
284-
cloudResourceManagerService, err := cloudresourcemanager3.New(client)
285+
cloudResourceManagerService, err := cloudresourcemanager3.NewService(ctx, option.WithHTTPClient(client))
285286
if err != nil {
286287
logger.Fatalf("Failed to get TagValues Service with error [%s], terminate execution", err.Error())
287288
}
288289
logger.Println("Got TagValues Service")
289290
return cloudResourceManagerService.TagValues
290291
}
291292

292-
func getFirewallPoliciesServiceOrTerminateExecution(client *http.Client) *compute.FirewallPoliciesService {
293+
func getFirewallPoliciesServiceOrTerminateExecution(ctx context.Context, client *http.Client) *compute.FirewallPoliciesService {
293294
logger.Println("Try to get Firewall Policies Service")
294-
computeService, err := compute.New(client)
295+
computeService, err := compute.NewService(ctx, option.WithHTTPClient(client))
295296
if err != nil {
296297
logger.Fatalf("Failed to get Firewall Policies Service with error [%s], terminate execution", err.Error())
297298
}
@@ -311,12 +312,12 @@ func initializeGoogleClient(ctx context.Context) *http.Client {
311312

312313
func invoke(ctx context.Context) {
313314
client := initializeGoogleClient(ctx)
314-
cloudResourceManagerService := getResourceManagerServiceOrTerminateExecution(client)
315-
folderService := getFolderServiceOrTerminateExecution(client)
316-
tagKeyService := getTagKeysServiceOrTerminateExecution(client)
317-
tagValuesService := getTagValuesServiceOrTerminateExecution(client)
318-
firewallPoliciesService := getFirewallPoliciesServiceOrTerminateExecution(client)
319-
endpointService := getServiceManagementServiceOrTerminateExecution(client)
315+
cloudResourceManagerService := getResourceManagerServiceOrTerminateExecution(ctx, client)
316+
folderService := getFolderServiceOrTerminateExecution(ctx, client)
317+
tagKeyService := getTagKeysServiceOrTerminateExecution(ctx, client)
318+
tagValuesService := getTagValuesServiceOrTerminateExecution(ctx, client)
319+
firewallPoliciesService := getFirewallPoliciesServiceOrTerminateExecution(ctx, client)
320+
endpointService := getServiceManagementServiceOrTerminateExecution(ctx, client)
320321

321322
removeLien := func(name string) {
322323
logger.Printf("Try to remove lien [%s]", name)

0 commit comments

Comments
 (0)