Skip to content

perf: optimize conditional rollup equality aggregates #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

perf: optimize conditional rollup equality aggregates #2034

merged 1 commit into from
Oct 23, 2025

Conversation

@nichenqin
Copy link
Contributor

No description provided.

@nichenqin nichenqin marked this pull request as draft October 23, 2025 08:02
@nichenqin nichenqin force-pushed the feat/conditional-rollup-aggregate-optimizations branch from 6948fe7 to f6e210f Compare October 23, 2025 08:23
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18743512690

Details

  • 272 of 304 (89.47%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 75.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/record/computed/services/computed-dependency-collector.service.ts 94 106 88.68%
apps/nestjs-backend/src/features/record/query-builder/field-cte-visitor.ts 178 198 89.9%
Totals Coverage Status
Change from base Build 18741229593: 0.06%
Covered Lines: 50591
Relevant Lines: 67220
💛 - Coveralls
@nichenqin nichenqin force-pushed the feat/conditional-rollup-aggregate-optimizations branch from f6e210f to 715890a Compare October 23, 2025 09:13
@nichenqin nichenqin added the preview This issue is already ready for preview label Oct 23, 2025
@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2034.sealoshzh.site
@nichenqin nichenqin marked this pull request as ready for review October 23, 2025 09:55
@nichenqin nichenqin merged commit 8b3cac4 into develop Oct 23, 2025
16 checks passed
@nichenqin nichenqin deleted the feat/conditional-rollup-aggregate-optimizations branch October 23, 2025 10:24
@github-actions
Copy link

🧹 Preview Environment Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview This issue is already ready for preview

4 participants

@nichenqin @coveralls @tea-artist