fix: add logging for record fetching and optimize foreign key updates in LinkService

Author: nichenqin

apps/nestjs-backend/src/features/calculation/link.service.ts

@@ -1,6 +1,6 @@
 /* eslint-disable sonarjs/cognitive-complexity */
 /* eslint-disable sonarjs/no-duplicate-string */
-import { BadRequestException, Injectable } from '@nestjs/common';
+import { Injectable, Logger } from '@nestjs/common';
 import type { ILinkCellValue, ILinkFieldOptions, IRecord } from '@teable/core';
 import { FieldType, HttpErrorCode, Relationship } from '@teable/core';
 import type { Field } from '@teable/db-main-prisma';
@@ -52,6 +52,7 @@ export interface ILinkCellContext {
 
 @Injectable()
 export class LinkService {
+  private logger = new Logger(LinkService.name);
   constructor(
     private readonly prismaService: PrismaService,
     private readonly batchService: BatchService,
@@ -826,6 +827,7 @@ export class LinkService {
       );
 
       const nativeQuery = qb.whereIn('__id', recordIds).toQuery();
+      this.logger.debug(`Fetch records with query: ${nativeQuery}`);
       const recordRaw = await this.prismaService
         .txClient()
         .$queryRawUnsafe<{ [dbTableName: string]: unknown }[]>(nativeQuery);
@@ -1361,32 +1363,26 @@ export class LinkService {
               );
             }
           } else {
-            // One-many without order column implies one-way using a junction table.
-            // To preserve the explicit order provided by the client (e.g., typecast "id1,id2"),
-            // delete all existing rows for this source record and re-insert in the new order.
-            const oldArr = oldKey ?? [];
-            const newArr = newKey ?? [];
-
-            const needsReorder =
-              oldArr.length !== newArr.length || !oldArr.every((key, i) => key === newArr[i]);
-
-            if (needsReorder) {
-              // Delete all existing associations for this source record
-              const deleteAllQuery = this.knex(fkHostTableName)
-                .where(selfKeyName, recordId)
-                .delete()
-                .toQuery();
-              await this.prismaService.txClient().$executeRawUnsafe(deleteAllQuery);
-
-              // Re-insert in the specified order
-              if (newArr.length) {
-                const insertValues = newArr.map((foreignRecordId) => ({
+            // One-many without an order column stores the FK directly on the foreign table.
+            // Only update rows where the foreign key actually changes.
+            const toAdd = difference(newKey, oldKey);
+
+            if (toAdd.length > 0) {
+              const dbFields = [{ dbFieldName: selfKeyName, schemaType: SchemaType.String }];
+
+              const addData = toAdd.map((foreignRecordId) => ({
+                id: foreignRecordId,
+                values: {
                   [selfKeyName]: recordId,
-                  [foreignKeyName]: foreignRecordId,
-                }));
-                const insertQuery = this.knex(fkHostTableName).insert(insertValues).toQuery();
-                await this.prismaService.txClient().$executeRawUnsafe(insertQuery);
-              }
+                },
+              }));
+
+              await this.batchService.batchUpdateDB(
+                fkHostTableName,
+                foreignKeyName,
+                dbFields,
+                addData
+              );
             }
           }
         }