Skip to content

Conversation

@nimohunter
Copy link

Describe the PR
add include , if include is set ,exclude path is invalid.

Relation issue
#905

Additional context
i find struct type define also be ignore by exclude args, so move the skip excloud path function and add include. Welcome to discuss this idea

@nimohunter nimohunter changed the title fix: add include, and exclude is invalid if include is set Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #906 (4c834ed) into master (17c1766) will decrease coverage by 0.78%.
The diff coverage is 18.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   84.83%   84.05%   -0.79%     
==========================================
  Files           8        8              
  Lines        1649     1668      +19     
==========================================
+ Hits         1399     1402       +3     
- Misses        145      159      +14     
- Partials      105      107       +2     
Impacted Files Coverage Δ
parser.go 80.44% <15.38%> (-1.57%) ⬇️
gen/gen.go 95.31% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c1766...4c834ed. Read the comment docs.

@Lehp
Copy link
Contributor

Lehp commented Mar 21, 2022

parser_test.go 3385 pretty nice example for your missing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants