Skip to content

Conversation

@Odonno
Copy link
Contributor

@Odonno Odonno commented Aug 5, 2025

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

Removes previously supported NamingPolicy property and supports the built-in Column attribute.

  • Remove NamingPolicy usage
  • Update tests
  • Update example projects
  • Update benchmark projects
  • Handle (de)serialization with Column attribute

What is your testing strategy?

Integration tests

Is this related to any issues?

N/A

Have you read the Contributing Guidelines?

@Odonno Odonno force-pushed the chore/remove-naming-policy branch from 4d90269 to 4fe8927 Compare August 19, 2025 10:19
@Odonno Odonno marked this pull request as ready for review August 19, 2025 10:19
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.80%. Comparing base (6fd2105) to head (a1d4b2d).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...rrealDb.Embedded.InMemory/SurrealDbMemoryClient.cs 0.00% 1 Missing ⚠️
...rrealDb.Embedded.RocksDb/SurrealDbRocksDbClient.cs 0.00% 1 Missing ⚠️
SurrealDb.Embedded.SurrealKv/SurrealDbKvClient.cs 0.00% 1 Missing ⚠️
...rrealDb.Net/Internals/Cbor/SurrealDbCborOptions.cs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   69.65%   70.80%   +1.15%     
==========================================
  Files         161      188      +27     
  Lines        6702     7593     +891     
  Branches      775      804      +29     
==========================================
+ Hits         4668     5376     +708     
- Misses       1689     1897     +208     
+ Partials      345      320      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@Odonno Odonno force-pushed the chore/remove-naming-policy branch from 4fe8927 to a1d4b2d Compare August 19, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant