Navigate to selected bookmark #5157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this pull request I made FavTreeItemClicked working for currently selected tree item. When there’s only one bookmark, you can navigate to it only once because navigation to the bookmark page happens in the FavTreeSelectionChanged callback. This callback is triggered only when a different tree element is selected. In the code, there’s also an onClick handler, but it was commented out in this commit: sumatrapdfreader@32b2981#diff-84fd94c3d33b1f12ded82c18e0ebb3ad66dde124291369437cd2782c21171e82 because of two related issues.: sumatrapdfreader#1716 sumatrapdfreader#2202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I made FavTreeItemClicked working for currently selected tree item.
When there’s only one bookmark, you can navigate to it only once because navigation to the bookmark page happens in the FavTreeSelectionChanged callback. This callback is triggered only when a different tree element is selected.
In the code, there’s also an onClick handler, but it was commented out in this commit: 32b2981
because of two related issues.:
#1716 #2202