Skip to content

Commit 7e66578

Browse files
authored
Merge pull request #1 from stormpath/peer-review
Code formatting and bug fixes
2 parents acfb207 + c7af880 commit 7e66578

File tree

11 files changed

+156
-118
lines changed

11 files changed

+156
-118
lines changed

‎.gitignore‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Created by .ignore support plugin (hsz.mobi)
2+
### JetBrains template
3+
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and Webstorm
4+
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
5+
6+
# User-specific stuff:
7+
.idea/
8+
9+
## File-based project format:
10+
*.iml
11+
*.iws
12+
13+
## Plugin-specific files:
14+
15+
# IntelliJ
16+
/out/
17+
18+
# mpeltonen/sbt-idea plugin
19+
.idea_modules/
20+
21+
# JIRA plugin
22+
atlassian-ide-plugin.xml
23+
24+
# Crashlytics plugin (for Android Studio and IntelliJ)
25+
com_crashlytics_export_strings.xml
26+
crashlytics.properties
27+
crashlytics-build.properties
28+
fabric.properties
29+
### Maven template
30+
target/
31+
pom.xml.tag
32+
pom.xml.releaseBackup
33+
pom.xml.versionsBackup
34+
pom.xml.next
35+
release.properties
36+
dependency-reduced-pom.xml
37+
buildNumber.properties
38+
.mvn/timing.properties

‎pom.xml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<parent>
1010
<groupId>org.springframework.boot</groupId>
1111
<artifactId>spring-boot-starter-parent</artifactId>
12-
<version>1.4.0.RELEASE</version>
12+
<version>1.4.1.RELEASE</version>
1313
</parent>
1414

1515
<dependencies>
@@ -40,10 +40,10 @@
4040
<groupId>com.h2database</groupId>
4141
<artifactId>h2</artifactId>
4242
</dependency>
43-
<dependency>
43+
<dependency>
4444
<groupId>com.stormpath.spring</groupId>
4545
<artifactId>stormpath-default-spring-boot-starter</artifactId>
46-
<version>1.1.0</version>
46+
<version>1.1.2</version>
4747
</dependency>
4848
</dependencies>
4949

@@ -58,5 +58,4 @@
5858
</plugin>
5959
</plugins>
6060
</build>
61-
62-
</project>
61+
</project>

‎src/main/java/tutorial/Application.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@SpringBootApplication
77
public class Application {
88

9-
public static void main(String[] args) {
10-
SpringApplication.run(Application.class, args);
11-
}
12-
}
9+
public static void main(String[] args) {
10+
SpringApplication.run(Application.class, args);
11+
}
12+
}
Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
package tutorial;
22

33
import org.springframework.beans.factory.annotation.Autowired;
4-
import org.springframework.stereotype.Component;
54
import org.springframework.boot.CommandLineRunner;
5+
import org.springframework.stereotype.Component;
66

77
@Component
88
public class DatabaseLoader implements CommandLineRunner {
99

10-
private final EmployeeRepository repository;
10+
private final EmployeeRepository repository;
1111

12-
@Autowired
13-
public DatabaseLoader(EmployeeRepository repository) {
14-
this.repository = repository;
15-
}
12+
@Autowired
13+
public DatabaseLoader(EmployeeRepository repository) {
14+
this.repository = repository;
15+
}
1616

17-
@Override
18-
public void run(String... strings) throws Exception {
19-
this.repository.save(new Employee("Joe Biden", 45, 5));
20-
this.repository.save(new Employee("President Obama", 54, 8));
21-
this.repository.save(new Employee("Crystal Mac", 34, 12));
22-
this.repository.save(new Employee("James Henry", 33, 2));
23-
}
24-
}
17+
@Override
18+
public void run(String... strings) throws Exception {
19+
this.repository.save(new Employee("Joe Biden", 45, 5));
20+
this.repository.save(new Employee("President Obama", 54, 8));
21+
this.repository.save(new Employee("Crystal Mac", 34, 12));
22+
this.repository.save(new Employee("James Henry", 33, 2));
23+
}
24+
}

‎src/main/java/tutorial/Employee.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
package tutorial;
22

3-
import javax.persistence.*;
43
import lombok.Data;
54

5+
import javax.persistence.Entity;
6+
import javax.persistence.GeneratedValue;
7+
import javax.persistence.Id;
8+
69
@Data
710
@Entity
811
public class Employee {
@@ -19,4 +22,4 @@ public Employee(String name, int age, int years) {
1922
this.age = age;
2023
this.years = years;
2124
}
22-
}
25+
}
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package tutorial;
22

33
import org.springframework.data.repository.CrudRepository;
4+
import org.springframework.security.access.prepost.PreAuthorize;
45

56
public interface EmployeeRepository extends CrudRepository<Employee, Long> {
67

7-
@PreAuthorize("hasAuthority('ROLE_ADMIN')")
8-
@Override
9-
void delete(Long aLong);
8+
@PreAuthorize("hasAuthority('ROLE_ADMIN')")
9+
@Override
10+
void delete(Long aLong);
1011

11-
}
12+
}

‎src/main/java/tutorial/HomeController.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
public class HomeController {
88

99
@RequestMapping(value = "/")
10-
public String index() {
11-
return "index";
12-
}
10+
public String index() {
11+
return "index";
12+
}
1313

14-
}
14+
}

‎src/main/java/tutorial/Security.java‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@
77
import static com.stormpath.spring.config.StormpathWebSecurityConfigurer.stormpath;
88

99
@Configuration
10-
public class Security extends WebSecurityConfigurerAdapter {
10+
public class Security extends WebSecurityConfigurerAdapter {
1111
@Override
1212
protected void configure(HttpSecurity http) throws Exception {
13-
http
14-
.apply(stormpath());
13+
http.apply(stormpath());
1514
}
16-
}
15+
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
spring.data.rest.base-path=/api
1+
spring.data.rest.basePath=/api
22

3-
stormpath.application.href =
4-
stormpath.client.apiKey.id =
5-
stormpath.client.apiKey.secret =
3+
stormpath.application.href =
4+
stormpath.client.apiKey.id =
5+
stormpath.client.apiKey.secret =

‎src/main/resources/templates/index.html‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,11 @@
2020
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.1.1/jquery.min.js"></script>
2121
<script src="https://cdnjs.cloudflare.com/ajax/libs/toastr.js/2.1.3/toastr.min.js"></script>
2222

23-
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/toastr.js/2.1.3/toastr.min.css"></link>
24-
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"></link>
23+
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/toastr.js/2.1.3/toastr.min.css"/>
24+
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"/>
2525

2626
<script type="text/babel" src="/public/app.js"></script>
2727

28-
2928
</body>
3029

3130
</html>

0 commit comments

Comments
 (0)