Fixing code inspection issues.

Author: stefanmielke

DataCore.Database.MySql/Properties/AssemblyInfo.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following

DataCore.Database.Oracle/OracleTranslator.cs

@@ -121,26 +121,26 @@ public override IEnumerable<string> GetCreateTableQuery(string tableName, IEnume
             yield return query.ToString();
 
             var identity = fieldList.FirstOrDefault(f => f.IsIdentity);
-            if (identity != null)
-            {
-                var sequenceName = tableName + "_sequence";
-                var triggerName = tableName + "_on_insert";
-
-                yield return string.Concat("CREATE SEQUENCE ", sequenceName);
-
-                query.Clear();
-                query.Append("CREATE OR REPLACE TRIGGER ");
-                query.Append(triggerName);
-                query.Append(" BEFORE INSERT ON ");
-                query.Append(tableName);
-                query.Append(" FOR EACH ROW BEGIN SELECT ");
-                query.Append(sequenceName);
-                query.Append(".nextval INTO :new.");
-                query.Append(identity.Name);
-                query.Append(" FROM dual; END;");
-
-                yield return query.ToString();
-            }
+            if (identity == null)
+                yield break;
+            
+            var sequenceName = tableName + "_sequence";
+            var triggerName = tableName + "_on_insert";
+
+            yield return string.Concat("CREATE SEQUENCE ", sequenceName);
+
+            query.Clear();
+            query.Append("CREATE OR REPLACE TRIGGER ");
+            query.Append(triggerName);
+            query.Append(" BEFORE INSERT ON ");
+            query.Append(tableName);
+            query.Append(" FOR EACH ROW BEGIN SELECT ");
+            query.Append(sequenceName);
+            query.Append(".nextval INTO :new.");
+            query.Append(identity.Name);
+            query.Append(" FROM dual; END;");
+
+            yield return query.ToString();
         }
 
         public override IEnumerable<string> GetCreateTableIfNotExistsQuery(string tableName, IEnumerable<FieldDefinition> fields)
@@ -157,26 +157,26 @@ public override IEnumerable<string> GetCreateTableIfNotExistsQuery(string tableN
             yield return CatchException(query.ToString(), -955);
 
             var identity = fieldList.FirstOrDefault(f => f.IsIdentity);
-            if (identity != null)
-            {
-                var sequenceName = tableName + "_sequence";
-                var triggerName = tableName + "_on_insert";
-
-                yield return CatchException(string.Concat("CREATE SEQUENCE ", sequenceName));
-
-                query.Clear();
-                query.Append("CREATE OR REPLACE TRIGGER ");
-                query.Append(triggerName);
-                query.Append(" BEFORE INSERT ON ");
-                query.Append(tableName);
-                query.Append(" FOR EACH ROW BEGIN SELECT ");
-                query.Append(sequenceName);
-                query.Append(".nextval INTO :new.");
-                query.Append(identity.Name);
-                query.Append(" FROM dual; END;");
-
-                yield return CatchException(query.ToString());
-            }
+            if (identity == null)
+                yield break;
+            
+            var sequenceName = tableName + "_sequence";
+            var triggerName = tableName + "_on_insert";
+
+            yield return CatchException(string.Concat("CREATE SEQUENCE ", sequenceName));
+
+            query.Clear();
+            query.Append("CREATE OR REPLACE TRIGGER ");
+            query.Append(triggerName);
+            query.Append(" BEFORE INSERT ON ");
+            query.Append(tableName);
+            query.Append(" FOR EACH ROW BEGIN SELECT ");
+            query.Append(sequenceName);
+            query.Append(".nextval INTO :new.");
+            query.Append(identity.Name);
+            query.Append(" FROM dual; END;");
+
+            yield return CatchException(query.ToString());
         }
 
         public override string GetCreateColumnQuery(string tableName, FieldDefinition field)
@@ -329,13 +329,13 @@ public override string GetAliasFormat()
             return "\"{0}\"";
         }
 
-        private string CatchException(string sql, int exceptionCode)
+        private static string CatchException(string sql, int exceptionCode)
         {
             return string.Concat("BEGIN EXECUTE IMMEDIATE '", sql, "' ; EXCEPTION WHEN OTHERS THEN IF SQLCODE != ",
                 exceptionCode, " THEN RAISE; END IF; END;");
         }
 
-        private string CatchException(string sql)
+        private static string CatchException(string sql)
         {
             return string.Concat("BEGIN EXECUTE IMMEDIATE '", sql, "' ; EXCEPTION WHEN OTHERS THEN NULL; END;");
         }

DataCore.Database.Oracle/Properties/AssemblyInfo.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following 

DataCore.Database.Postgres/Properties/AssemblyInfo.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following

DataCore.Database.SqlServer/Properties/AssemblyInfo.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following 

DataCore.Database.Sqlite/Properties/AssemblyInfo.cs

@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following