Skip to content

fix: cross schema inherits #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: cross schema inherits #4129

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27d7454
fix: inherits now uses the schema of the inherited table and not the …
axlalmflower Oct 7, 2025
2e22a8f
fix: wrong schema in postgresql/stdlib/schema.sql
axlalmflower Oct 7, 2025
24de49e
fix: fix queries in postgresql/stdlib/query.sql
axlalmflower Oct 7, 2025
d416291
fix: updated all queries in tests
axlalmflower Oct 7, 2025
2d4b83b
chore: generate test files
axlalmflower Oct 7, 2025
d28b011
fix: fall back to default/public schema if no schema present
axlalmflower Oct 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: fall back to default/public schema if no schema present
  • Loading branch information
@axlalmflower
axlalmflower committed Oct 7, 2025
commit d28b0110623f3b9ee40073ff17d23a68efae4f7e
15 changes: 11 additions & 4 deletions internal/sql/catalog/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,15 +268,22 @@ func (c *Catalog) createTable(stmt *ast.CreateTableStmt) error {
seen := make(map[string]bool) // used to check for duplicate column names
for _, inheritTable := range stmt.Inherits {

inheritSchema, err := c.getSchema(inheritTable.Schema)
if err != nil {
return err
var inheritTableSchema *Schema
if inheritTable.Schema == "" {
inheritTableSchema = schema
} else {
inheritSchema, err := c.getSchema(inheritTable.Schema)
if err != nil {
return err
}
inheritTableSchema = inheritSchema
}

t, _, err := inheritSchema.getTable(inheritTable)
t, _, err := inheritTableSchema.getTable(inheritTable)
if err != nil {
return err
}

// check and ignore duplicate columns
for _, col := range t.Columns {
if notNull, ok := seen[col.Name]; ok {
Expand Down
Loading