Skip to content

fix: cross schema inherits #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: cross schema inherits #4129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27d7454
fix: inherits now uses the schema of the inherited table and not the …
axlalmflower Oct 7, 2025
2e22a8f
fix: wrong schema in postgresql/stdlib/schema.sql
axlalmflower Oct 7, 2025
24de49e
fix: fix queries in postgresql/stdlib/query.sql
axlalmflower Oct 7, 2025
d416291
fix: updated all queries in tests
axlalmflower Oct 7, 2025
2d4b83b
chore: generate test files
axlalmflower Oct 7, 2025
d28b011
fix: fall back to default/public schema if no schema present
axlalmflower Oct 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: generate test files
  • Loading branch information
@axlalmflower
axlalmflower committed Oct 7, 2025
commit 2d4b83b4bd2b43701351f201e2e1d99d04b63395
23 changes: 4 additions & 19 deletions ...l/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v4/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 8 additions & 32 deletions ...ndtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v4/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...rnal/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v4/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- name: GetAllParties :many
SELECT * FROM one.party;
SELECT * FROM parent.party;

-- name: GetAllPeople :many
SELECT * FROM two.person;
SELECT * FROM child.person;

10 changes: 5 additions & 5 deletions ...nal/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v4/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
CREATE SCHEMA one;
CREATE SCHEMA two;
CREATE SCHEMA parent;
CREATE SCHEMA child;

CREATE TABLE one.party (
CREATE TABLE parent.party (
party_id uuid PRIMARY KEY,
name text NOT NULL
);

CREATE TABLE two.person (
CREATE TABLE child.person (
first_name text NOT NULL,
last_name text NOT NULL
) INHERITS (one.party);
) INHERITS (parent.party);

21 changes: 4 additions & 17 deletions ...l/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v5/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 8 additions & 32 deletions ...ndtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v5/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...rnal/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v5/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- name: GetAllParties :many
SELECT * FROM one.party;
SELECT * FROM parent.party;

-- name: GetAllPeople :many
SELECT * FROM two.person;
SELECT * FROM child.person;

10 changes: 5 additions & 5 deletions ...nal/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/pgx/v5/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
CREATE SCHEMA one;
CREATE SCHEMA two;
CREATE SCHEMA parent;
CREATE SCHEMA child;

CREATE TABLE one.party (
CREATE TABLE parent.party (
party_id uuid PRIMARY KEY,
name text NOT NULL
);

CREATE TABLE two.person (
CREATE TABLE child.person (
first_name text NOT NULL,
last_name text NOT NULL
) INHERITS (one.party);
) INHERITS (parent.party);

23 changes: 4 additions & 19 deletions ...l/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/stdlib/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 8 additions & 35 deletions ...ndtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/stdlib/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...rnal/endtoend/testdata/ddl_create_table_inherits_cross_schema/postgresql/stdlib/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- name: GetAllParties :many
SELECT * FROM one.party;
SELECT * FROM parent.party;

-- name: GetAllPeople :many
SELECT * FROM two.person;
SELECT * FROM child.person;

Loading
Loading