Skip to content

bugfix: Normalize identifier usage for table names #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

bugfix: Normalize identifier usage for table names #4045

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfbb1e5
fix normalize identifier for table names
Mr-Destructive Aug 7, 2025
dcca536
add tests for case sensitive table operations
Mr-Destructive Aug 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix normalize identifier for table names
  • Loading branch information
@Mr-Destructive
Mr-Destructive committed Aug 7, 2025
commit bfbb1e5b8db025ba0c88fd0599d1ca7c3e0b27ac
10 changes: 5 additions & 5 deletions internal/engine/sqlite/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@ func NewIdentifier(t string) *ast.String {
func (c *cc) convertAlter_table_stmtContext(n *parser.Alter_table_stmtContext) ast.Node {
if n.RENAME_() != nil {
if newTable, ok := n.New_table_name().(*parser.New_table_nameContext); ok {
name := newTable.Any_name().GetText()
name := identifier(newTable.Any_name().GetText())
return &ast.RenameTableStmt{
Table: parseTableName(n),
NewName: &name,
}
}

if newCol, ok := n.GetNew_column_name().(*parser.Column_nameContext); ok {
name := newCol.Any_name().GetText()
name := identifier(newCol.Any_name().GetText())
return &ast.RenameColumnStmt{
Table: parseTableName(n),
Col: &ast.ColumnRef{
Name: n.GetOld_column_name().GetText(),
Name: identifier(n.GetOld_column_name().GetText()),
},
NewName: &name,
}
Expand Down Expand Up @@ -254,7 +254,7 @@ func (c *cc) convertDelete_stmtContext(n Delete_stmt) ast.Node {
func (c *cc) convertDrop_stmtContext(n *parser.Drop_stmtContext) ast.Node {
if n.TABLE_() != nil || n.VIEW_() != nil {
name := ast.TableName{
Name: n.Any_name().GetText(),
Name: identifier(n.Any_name().GetText()),
}
if n.Schema_name() != nil {
name.Schema = n.Schema_name().GetText()
Expand Down Expand Up @@ -1035,7 +1035,7 @@ func (c *cc) convertUpdate_stmtContext(n Update_stmt) ast.Node {
}

relations := &ast.List{}
tableName := n.Qualified_table_name().GetText()
tableName := identifier(n.Qualified_table_name().GetText())
rel := ast.RangeVar{
Relname: &tableName,
Location: n.GetStart().GetStart(),
Expand Down
Loading