Skip to content

Add rowid column to FTS5 tables #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rowid column to FTS5 tables #3902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add rowid column to FTS5 tables
  • Loading branch information
@ajeetdsouza
ajeetdsouza committed Mar 26, 2025
commit 6d958871f08c1c9d018ef380e1d892cec6fe3319
8 changes: 5 additions & 3 deletions internal/endtoend/testdata/virtual_table/sqlite/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 31 additions & 8 deletions internal/endtoend/testdata/virtual_table/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions internal/endtoend/testdata/virtual_table/sqlite/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
-- name: SelectRowID :one
SELECT rowid FROM ft
LIMIT 1;

-- name: SelectAllColsFt :many
SELECT b FROM ft
WHERE b MATCH ?;
Expand Down
7 changes: 7 additions & 0 deletions internal/engine/sqlite/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ func (c *cc) convertCreate_virtual_table_fts5(n *parser.Create_virtual_table_stm
IfNotExists: n.EXISTS_() != nil,
}

// All FTS5 virtual tables implicitly contain a 'rowid' column.
stmt.Cols = append(stmt.Cols, &ast.ColumnDef{
Colname: "rowid",
IsNotNull: true,
TypeName: &ast.TypeName{Name: "integer"},
})

for _, arg := range n.AllModule_argument() {
var columnName string

Expand Down
Loading