Skip to content

fix(postgresql): set query result column nullable if selected column contains json operator or null value in case expression #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(postgresql): set query result column nullable if selected column contains json operator or null value in case expression #3739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ea4ce3
feat: adding nullable text if selected column is json operator and ca…
swallowstalker Dec 10, 2024
25274e8
test: fix fmt
swallowstalker Dec 10, 2024
f61bfcc
test: delete fourth column
swallowstalker Dec 10, 2024
049fb49
test: avoid test format because the reversed query from raw statement…
swallowstalker Dec 10, 2024
ebc8a77
feat: case expr handling and json operator handling
swallowstalker Dec 12, 2024
f154a2f
fix: change managed-db to base
swallowstalker Dec 12, 2024
822e73f
test: add null::text as default case expr
swallowstalker Dec 13, 2024
e7ddabf
test: changing author email
swallowstalker Dec 13, 2024
d0cbfe4
Merge branch 'main' into text-alias
swallowstalker Dec 19, 2024
409d2fb
fix: change type precedence auto-selection to data type any, to allow…
swallowstalker Dec 19, 2024
19ab642
test: uncommitted test case for GetNullable2G
swallowstalker Dec 19, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add null::text as default case expr
  • Loading branch information
@swallowstalker
swallowstalker committed Dec 13, 2024
commit 822e73fb30eaca38b41f8b585da4deaee0522ad5
25 changes: 25 additions & 0 deletions ...oend/testdata/json_traversal_as_select_expr_with_type_cast/postgresql/pgx/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ...l/endtoend/testdata/json_traversal_as_select_expr_with_type_cast/postgresql/pgx/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ FROM "mytable";
SELECT CASE WHEN true THEN 'hello'::text ELSE null END
FROM "mytable";

-- name: GetNullable3B :many
SELECT CASE WHEN true THEN 'hello'::text ELSE null::text END
FROM "mytable";

-- name: GetNullable4 :many
SELECT CASE WHEN true THEN 'hello'::text END
FROM "mytable";
Expand Down