Skip to content

feat: Managed databases with any accessible server #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2024
+226 −37
Merged

feat: Managed databases with any accessible server #3421

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90c5d68
First pass
kyleconroy Jun 5, 2024
bdb3ba2
add engine to servers
kyleconroy Jun 5, 2024
7fa36d7
detect url with no spaces
kyleconroy Jun 5, 2024
d053086
remove extra logging
kyleconroy Jun 5, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove extra logging
  • Loading branch information
@kyleconroy
kyleconroy committed Jun 5, 2024
commit d053086468a39b54e47b2b0fc5b40fe1cc96355b
3 changes: 0 additions & 3 deletions internal/dbmanager/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"fmt"
"hash/fnv"
"io"
"log/slog"
"net/url"
"strings"

Expand Down Expand Up @@ -83,11 +82,9 @@ func (m *ManagedClient) CreateDatabase(ctx context.Context, req *CreateDatabaseR

var datname string
if err := row.Scan(&datname); err == nil {
slog.Info("database exists", "name", name)
return nil, nil
}

slog.Info("creating database", "name", name)
if _, err := pool.Exec(ctx, fmt.Sprintf(`CREATE DATABASE "%s"`, name)); err != nil {
return nil, err
}
Expand Down