Skip to content

feat: Managed databases with any accessible server #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2024
+226 −37
Merged

feat: Managed databases with any accessible server #3421

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90c5d68
First pass
kyleconroy Jun 5, 2024
bdb3ba2
add engine to servers
kyleconroy Jun 5, 2024
7fa36d7
detect url with no spaces
kyleconroy Jun 5, 2024
d053086
remove extra logging
kyleconroy Jun 5, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
detect url with no spaces
  • Loading branch information
@kyleconroy
kyleconroy committed Jun 5, 2024
commit 7fa36d7cd00eddf136a35d906daed9368efbf5b1
4 changes: 2 additions & 2 deletions internal/dbmanager/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ func (m *ManagedClient) CreateDatabase(ctx context.Context, req *CreateDatabaseR
}
}

if base == "" {
return nil, fmt.Errorf("no postgres server found")
if strings.TrimSpace(base) == "" {
return nil, fmt.Errorf("no PostgreSQL database server found")
}

serverUri := m.replacer.Replace(base)
Expand Down