Skip to content

feat: Generate read-only Queries #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Generate read-only Queries #3291

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d373474
Generate read-only Queries
jarri-abidi Mar 25, 2024
d4666b6
Handle DELETE
jarri-abidi Mar 25, 2024
771c044
Fix bug where column called updated_at was being skipped in readonly …
jarri-abidi Mar 26, 2024
f50efd8
Exclude SELECT FOR UPDATE queries from readonly ones
jarri-abidi Mar 28, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle DELETE
  • Loading branch information
@jarri-abidi
jarri-abidi committed Mar 25, 2024
commit d4666b690d4ba05e23b1b36d12a19ed4b2f39045
4 changes: 3 additions & 1 deletion internal/codegen/golang/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,9 @@ func readOnly(queries []Query) []Query {
if !strings.Contains(qsql, "SELECT") {
continue
}
if strings.Contains(qsql, "UPDATE") || strings.Contains(qsql, "INSERT") {
if strings.Contains(qsql, "INSERT") ||
strings.Contains(qsql, "UPDATE") ||
strings.Contains(qsql, "DELETE") {
continue
}

Expand Down