Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bug where column called updated_at was being skipped in readonly …
…queries
  • Loading branch information
jarri-abidi committed Mar 26, 2024
commit 771c0441f0c3f08d51339c5cdf185486aface491
8 changes: 4 additions & 4 deletions internal/codegen/golang/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,12 +424,12 @@ func readOnly(queries []Query) []Query {
}

qsql := strings.ToUpper(q.SQL)
if !strings.Contains(qsql, "SELECT") {
if !strings.Contains(qsql, "SELECT ") {
continue
}
if strings.Contains(qsql, "INSERT") ||
strings.Contains(qsql, "UPDATE") ||
strings.Contains(qsql, "DELETE") {
if strings.Contains(qsql, "INSERT ") ||
strings.Contains(qsql, "UPDATE ") ||
strings.Contains(qsql, "DELETE ") {
continue
}

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* name: GetUserByID :one */
SELECT first_name, id, last_name FROM users WHERE id = sqlc.arg('target_id');
SELECT first_name, id, last_name, updated_at FROM users WHERE id = sqlc.arg('target_id');

/* name: ListUsers :many */
SELECT first_name, last_name FROM users;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CREATE TABLE users (
id SERIAL NOT NULL,
first_name varchar(255) NOT NULL,
last_name varchar(255)
last_name varchar(255),
updated_at timestamp NULL DEFAULT CURRENT_TIMESTAMP
);

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* name: GetUserByID :one */
SELECT first_name, id, last_name FROM users WHERE id = sqlc.arg('target_id');
SELECT first_name, id, last_name, updated_at FROM users WHERE id = sqlc.arg('target_id');

/* name: ListUsers :many */
SELECT first_name, last_name FROM users;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
CREATE TABLE users (
id SERIAL NOT NULL,
first_name varchar(255) NOT NULL,
last_name varchar(255)
last_name varchar(255),
updated_at timestamp NULL DEFAULT CURRENT_TIMESTAMP
);