Skip to content

enable go_struct_tag on column types #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

enable go_struct_tag on column types #3287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95f8536
enable go_struct_tag on column types
emanuelturis Mar 22, 2024
e97452e
match on null or not null
emanuelturis Mar 22, 2024
688cc9a
fix nullable
emanuelturis Mar 22, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
match on null or not null
  • Loading branch information
@emanuelturis
emanuelturis committed Mar 22, 2024
commit e97452e6949f14d2a8e673257b1b456522df9c15
2 changes: 1 addition & 1 deletion internal/codegen/golang/go_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func addExtraGoStructTags(tags map[string]string, req *plugin.GenerateRequest, o
if oride.GoType.StructTags == nil {
continue
}
dbTypeMatches := col.Type.Name == oride.DbType
dbTypeMatches := col.Type.Name == oride.DbType && col.NotNull == oride.Nullable
if !dbTypeMatches && !override.Matches(col.Table, req.Catalog.DefaultSchema) {
// Different table.
continue
Expand Down