Skip to content

feat(sql/ast): Render AST to SQL #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 12, 2023
Merged

feat(sql/ast): Render AST to SQL #2815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
feab40b
feat(sql/ast): Early support for rendering SQL AST
kyleconroy Oct 6, 2023
2912c86
Support a few more nodes
kyleconroy Oct 7, 2023
e1479b5
Print more nodes
kyleconroy Oct 11, 2023
6e6d1f3
Test all queries in endtoend
kyleconroy Oct 11, 2023
8a9a3c8
More Format
kyleconroy Oct 11, 2023
f566907
Close to all tests passing
kyleconroy Oct 11, 2023
fe5d5c3
fmt
kyleconroy Oct 12, 2023
872127d
All tests pass (for now)
kyleconroy Oct 12, 2023
3ee1612
sometime move package to not main
kyleconroy Oct 12, 2023
c30e1f7
fix tests (again)
kyleconroy Oct 12, 2023
15c8702
merge
kyleconroy Oct 12, 2023
43ec6f1
fix
kyleconroy Oct 12, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests (again)
  • Loading branch information
@kyleconroy
kyleconroy committed Oct 12, 2023
commit c30e1f797b0a5f20ae4731d26dff3ec4cffd1232
42 changes: 42 additions & 0 deletions internal/endtoend/testdata/materialized_views/postgresql/stdlib/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions internal/engine/postgresql/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2982,7 +2982,6 @@ func convertXmlSerialize(n *pg.XmlSerialize) *ast.XmlSerialize {

func convertNode(node *pg.Node) ast.Node {
if node == nil || node.Node == nil {
// TODO: WHY
return &ast.TODO{}
}

Expand Down Expand Up @@ -3643,7 +3642,6 @@ func convertNode(node *pg.Node) ast.Node {
return convertXmlSerialize(n.XmlSerialize)

default:
fmt.Printf("todo: %T\n", n)
return &ast.TODO{}
}
}