Skip to content

fix(codegen): use correct Go types for bit strings and cid/oid/tid/xid with pgx/v4 #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix(codegen): use correct Go types for bit strings and cid/oid/tid/xid with pgx/v4 #2668

merged 1 commit into from
Aug 30, 2023

Conversation

@andrewmbenton
Copy link
Collaborator

resolves #2667
kyleconroy
kyleconroy approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests would have caught the issue, as the code wouldn't compile.
@kyleconroy kyleconroy added this to the 1.21.0 milestone Aug 28, 2023
@kyleconroy kyleconroy merged commit faa1c9d into main Aug 30, 2023
@kyleconroy kyleconroy deleted the andrew/fix-pgx-v4-types branch August 30, 2023 15:31
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@andrewmbenton
fix(codegen): use correct Go types for bit strings and cid/oid/tid/xi…
3f0010d 
…d with pgx/v4 (sqlc-dev#2668)

resolves sqlc-dev#2667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@andrewmbenton @kyleconroy