Skip to content

fix Go struct tag parsing #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix Go struct tag parsing #2606

merged 1 commit into from
Aug 28, 2023

Conversation

@josharian
Copy link
Contributor

304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)

Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.
@josharian
fix Go struct tag parsing
18f3d48 
304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)

Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.
@josharian josharian force-pushed the josh/go-struct-tag-parsing branch from ae83ce7 to 18f3d48 Compare August 11, 2023 21:29
@kyleconroy kyleconroy merged commit 9c58a60 into sqlc-dev:main Aug 28, 2023
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@josharian
fix(config): Go struct tag parsing (sqlc-dev#2606)
607a92d 
304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)

Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@josharian @kyleconroy