Skip to content

Fix code geneation for sqlc.slice #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix code geneation for sqlc.slice #2431

merged 1 commit into from
Jul 26, 2023

Conversation

@SoMuchForSubtlety
Copy link
Contributor

Fixes #2430
@SoMuchForSubtlety
Copy link
Contributor Author

Generating the prepared statement should probably also be skipped, but this fixes the core issue.
@Jille
Copy link
Contributor

Jille commented Jul 13, 2023

Heh, I ran into the same issue and wrote the exact same PR :D
@andrewmbenton
Copy link
Collaborator

This reveals the issue referenced in #2452 but I suppose it's best to work on that in a separate PR.
@andrewmbenton andrewmbenton added this to the v1.20.0 milestone Jul 26, 2023
@andrewmbenton andrewmbenton merged commit 3a67691 into sqlc-dev:main Jul 26, 2023
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@SoMuchForSubtlety
fix(sqlite): code generation for sqlc.slice (sqlc-dev#2431)
a673247 
Fixes sqlc-dev#2430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@SoMuchForSubtlety @Jille @andrewmbenton