Fix broken interaction between query_parameter_limit and pq.Array() #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed to understand PostgreSQL IN() which doens't surface as an *ast.In
The sqlc.slice() templating code needed to understand how to refer to a variable when query_parameter_limit prevented struct emission. issue sqlc-dev#2268
The pq import was missing in those cases. I ran into this while writing a test case for sqlc-dev#2268 comment 2.
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
…qlc-dev#2383) * Understand sqlc.slice() in more expression types This was needed to understand PostgreSQL IN() which doens't surface as an *ast.In * Fix interaction between query_parameter_limit and sqlc.slice() The sqlc.slice() templating code needed to understand how to refer to a variable when query_parameter_limit prevented struct emission. issue sqlc-dev#2268 * Fix imports if a file has both sqlc.slice() and regular arrays The pq import was missing in those cases. I ran into this while writing a test case for sqlc-dev#2268 comment 2. * Fix broken interaction between query_parameter_limit and pq.Array() issue sqlc-dev#2268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2268 (second comment)